Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts Axis - hideFirstMajorUnit/hideLastMajorUnit bug fix. #1382

Closed
tripp opened this issue Nov 12, 2013 · 1 comment
Closed

Charts Axis - hideFirstMajorUnit/hideLastMajorUnit bug fix. #1382

tripp opened this issue Nov 12, 2013 · 1 comment
Labels
bug Charts
Milestone
Sprint 11 Code Fr...

Comments

@tripp
Copy link
Contributor

tripp commented Nov 12, 2013

The Axis class has attributes hideFirstMajorUnit and hideLastMajorUnit. When set to true, the corresponding label and tick will not be rendered on the axis. Currently the implementation removes them as values from the respective labelValues and tickPoints attributes. This is not the best solution as it can alter calculations that calculations that may rely on an accurate count. I plan on updating the Axis class so that the values are not deleted when the label/tick aren't rendered.
@ghost ghost assigned tripp Nov 13, 2013
@tripp tripp mentioned this issue Nov 13, 2013
Merged
12 tasks
@tripp
Copy link
Contributor Author

tripp commented Nov 16, 2013

PR #1386 has been merged into dev-3.x

@tripp tripp closed this as completed Nov 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Charts
Projects
None yet
Milestone
Sprint 11 Code Freeze
Development

No branches or pull requests
1 participant
@tripp