fix: blocking some prefixes of milestone/feature/issue title

Author: yeqown

.gitignore

@@ -4,7 +4,7 @@
 *.dll
 *.so
 *.dylib
-
+.DS_Store
 # Test binary, built with `go test -c`
 *.test
 

cmd/gitlab-flow/commands.go

@@ -80,7 +80,7 @@ func getFeatureCommand() *cli.Command {
 			},
 			&cli.BoolFlag{
 				Name:     "parse-issue-compatible",
-				Usage:    "switch to parse issue name in comptaible mode",
+				Usage:    "switch to parse issue name in compatible mode",
 				Required: false,
 			},
 		},

cmd/gitlab-flow/commands_feature.go

@@ -22,7 +22,7 @@ func getFeatureSubCommands() cli.Commands {
 }
 
 // getFeatureBeginSubCommand to start feature command
-// command: gitlab-flow feature start @title @desc
+// @command: gitlab-flow feature start @title @desc
 // @title will be used as branchName
 // @desc will be used as milestone information
 func getFeatureBeginSubCommand() *cli.Command {

internal/flow.go

@@ -166,6 +166,28 @@ func genIssueBranchName(name string, issueIID int) string {
 	return IssueBranchPrefix + name + "-" + strconv.Itoa(issueIID)
 }
 
+func blockingNamePrefix(name string) error {
+	if len(name) == 0 || (len(name) <= 3 && name != "/") {
+		return nil
+	}
+
+	// FIXED(@yeqown): blocking some prefixes to be milestone title.
+	blacklist := []string{
+		"/", "bug/", "test/", "issue/", // test-like
+		"fix/", "refactor/", "docs/", "chore/", // commit-like
+		"master/", "develop/", "hotfix/", "release/", "feature/", // branch-like
+		"WIP:", // others
+	}
+
+	for _, pre := range blacklist {
+		if strings.HasPrefix(name, pre) {
+			return fmt.Errorf("title(%s) should not start with prefix(%s)", name, pre)
+		}
+	}
+
+	return nil
+}
+
 // parseFeatureFromIssueName parse issue name to feature name, there are
 // two different cases:
 // 1. "1-milestoneName"

internal/flow_impl.go

@@ -201,6 +201,10 @@ func (f flowImpl) FeatureBegin(opc *types.OpFeatureContext, title, desc string)
 		}).
 		Debug("FeatureBegin called")
 
+	if err := blockingNamePrefix(title); err != nil {
+		return errors.Wrap(err, "blocking name prefix detected")
+	}
+
 	// create milestone
 	result, err := f.createMilestone(title, desc)
 	if err != nil {
@@ -320,6 +324,10 @@ func (f flowImpl) FeatureBeginIssue(opc *types.OpFeatureContext, title, desc str
 
 	if len(title) == 0 {
 		title = milestone.Title
+	} else {
+		if err := blockingNamePrefix(title); err != nil {
+			return errors.Wrap(err, "blocking name prefix detected")
+		}
 	}
 	if len(desc) == 0 {
 		desc = milestone.Desc