Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs in terminal impossible to read #397

Closed
imjared opened this issue Nov 8, 2013 · 3 comments · Fixed by #399
Closed

Diffs in terminal impossible to read #397

imjared opened this issue Nov 8, 2013 · 3 comments · Fixed by #399

Comments

@imjared
Copy link
Contributor

imjared commented Nov 8, 2013

I'm using .zsh with a solarized dark theme and the diffs output in terminal are impossible to read.

Perhaps we can force black text on the green? I recognize this may not be a yeoman-specific issue but flagging here before marching down the dependency chain.

screen shot 2013-11-08 at 12 46 37 pm

@SBoudrias
Copy link
Member

That make sense. Care to send a PR?

@imjared
Copy link
Contributor Author

imjared commented Nov 8, 2013

Looks like this is more an issue with solarized than with anything in the generator: altercation/solarized#220. Will see if there's a viable workaround and PR if possible.

@SBoudrias
Copy link
Member

Yes, this sure is related to solarized and the colors levels you set in your configs. (You can edit those too so your color are outputted directly)

But outputting black text would ensure correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants