Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total No. of meta_filtered_uids is 296k instead of 150k+50k+50k mentioned in the paper. #3

Closed
charchit7 opened this issue Mar 31, 2024 · 3 comments

Comments

@charchit7
Copy link

charchit7 commented Mar 31, 2024

Hey Yash,

I really liked your paper. The general idea is interesting and I am trying out some personal experiments on objaverse.
I noticed that the data filtering code produces 298k uids instead of 250k.

Could you please tell why is that the case.
image

@charchit7 charchit7 changed the title Total No. of meta_filtered_uids is 296k instead of 150k mentioned in the paper. Total No. of meta_filtered_uids is 296k instead of 150k+50k+50k mentioned in the paper. Apr 1, 2024
@charchit7
Copy link
Author

@yashkant apologies for 150k, as it's mentioned 150k+50k+50k. Extra 46k is for overlapping?

@yashkant
Copy link
Owner

yashkant commented Apr 1, 2024

hey @charchit7, thanks for checking out spad!

we missed to clarify that we take a union of our filtered objects in the paper text — this leads to a final dataset size of ~296K (as you noticed). i will add this clarification to our readme.

in my experience, using a high quality subset of objaverse and a strong base model (SDXL) is much more important than total samples. for example, instant3d only trained on 10K assets, and still generates good results.

hope this helps!

@yashkant yashkant closed this as completed Apr 1, 2024
@charchit7
Copy link
Author

charchit7 commented Apr 2, 2024

Thank you, Yash, for clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants