Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn upgrade breaks @hot-loader/react-dom alias #7062

Open
esetnik opened this issue Feb 25, 2019 · 1 comment
Open

Yarn upgrade breaks @hot-loader/react-dom alias #7062

esetnik opened this issue Feb 25, 2019 · 1 comment
Labels

Comments

@esetnik
Copy link

esetnik commented Feb 25, 2019

Do you want to request a feature or report a bug?

Bug

What is the current behavior?
@hot-loader/react-dom is installed following instructions:

yarn add react-dom@npm:@hot-loader/react-dom

yarn outdated shows react-dom as exotic

❯ yarn outdated
yarn outdated v1.13.0
info Color legend :
 "<red>"    : Major Update backward-incompatible updates
 "<yellow>" : Minor Update backward-compatible features
 "<green>"  : Patch Update backward-compatible bug fixes
Package   Current Wanted Latest Package Type URL
react-dom 16.8.2  exotic exotic dependencies npm:@hot-loader/react-dom
✨  Done in 2.46s.

package.json before yarn upgrade:

{
  "dependencies": {
    "@hot-loader/react-dom": "^16.8.2",
    "react-dom": "npm:@hot-loader/react-dom",
  }
}

package.json after yarn upgrade:

{
  "dependencies": {
    "@hot-loader/react-dom": "npm:@hot-loader/react-dom",
    "react-dom": "npm:@hot-loader/react-dom",
  }
}

If the current behavior is a bug, please provide the steps to reproduce.

See above

What is the expected behavior?
The package.json should not erase the alias

Please mention your node.js, yarn and operating system version.

❯ node -v && yarn -v && sw_vers
v10.15.0
1.13.0
ProductName:	Mac OS X
ProductVersion:	10.14.3
BuildVersion:	18D109
@Jessidhia
Copy link

I'm not sure but it just seems package aliases are behaving... strangely. Not sure if connected to workspaces, or to scoped packages.

I could reproduce it a few days ago with babel-preset-env@npm:@babel/preset-env, but I'm not affected anymore (for now) as I no longer need the hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants