@@ -397,8 +397,8 @@ rcl_parse_arguments(
397
397
if (i + 1 < argc ) {
398
398
// Attempt to parse next argument as parameter override rule
399
399
if (RCL_RET_OK == _rcl_parse_param_rule (argv [i + 1 ], args_impl -> parameter_overrides )) {
400
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
401
- "Got param override rule : %s\n" , argv [i + 1 ]);
400
+ RCUTILS_LOG_DEBUG_NAMED (
401
+ ROS_PACKAGE_NAME , "Got param override rule : %s\n" , argv [i + 1 ]);
402
402
++ i ; // Skip flag here, for loop will skip rule.
403
403
continue ;
404
404
}
@@ -414,8 +414,8 @@ rcl_parse_arguments(
414
414
ret = RCL_RET_INVALID_ROS_ARGS ;
415
415
goto fail ;
416
416
}
417
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
418
- "Arg %d (%s) is not a %s nor a %s flag." ,
417
+ RCUTILS_LOG_DEBUG_NAMED (
418
+ ROS_PACKAGE_NAME , "Arg %d (%s) is not a %s nor a %s flag." ,
419
419
i , argv [i ], RCL_PARAM_FLAG , RCL_SHORT_PARAM_FLAG );
420
420
421
421
// Attempt to parse argument as remap rule flag
@@ -442,9 +442,9 @@ rcl_parse_arguments(
442
442
ret = RCL_RET_INVALID_ROS_ARGS ;
443
443
goto fail ;
444
444
}
445
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
446
- "Arg %d (%s) is not a %s nor a %s flag." , i ,
447
- argv [i ], RCL_REMAP_FLAG , RCL_SHORT_REMAP_FLAG );
445
+ RCUTILS_LOG_DEBUG_NAMED (
446
+ ROS_PACKAGE_NAME , "Arg %d (%s) is not a %s nor a %s flag." ,
447
+ i , argv [i ], RCL_REMAP_FLAG , RCL_SHORT_REMAP_FLAG );
448
448
449
449
// Attempt to parse argument as parameter file rule
450
450
if (strcmp (RCL_PARAM_FILE_FLAG , argv [i ]) == 0 ) {
@@ -457,7 +457,8 @@ rcl_parse_arguments(
457
457
& args_impl -> parameter_files [args_impl -> num_param_files_args ]))
458
458
{
459
459
++ (args_impl -> num_param_files_args );
460
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
460
+ RCUTILS_LOG_DEBUG_NAMED (
461
+ ROS_PACKAGE_NAME ,
461
462
"Got params file : %s\ntotal num param files %d" ,
462
463
args_impl -> parameter_files [args_impl -> num_param_files_args - 1 ],
463
464
args_impl -> num_param_files_args );
@@ -476,8 +477,9 @@ rcl_parse_arguments(
476
477
ret = RCL_RET_INVALID_ROS_ARGS ;
477
478
goto fail ;
478
479
}
479
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
480
- "Arg %d (%s) is not a %s flag." , i , argv [i ], RCL_PARAM_FILE_FLAG );
480
+ RCUTILS_LOG_DEBUG_NAMED (
481
+ ROS_PACKAGE_NAME , "Arg %d (%s) is not a %s flag." ,
482
+ i , argv [i ], RCL_PARAM_FILE_FLAG );
481
483
482
484
// Attempt to parse argument as log level configuration
483
485
if (strcmp (RCL_LOG_LEVEL_FLAG , argv [i ]) == 0 ) {
@@ -501,25 +503,25 @@ rcl_parse_arguments(
501
503
ret = RCL_RET_INVALID_ROS_ARGS ;
502
504
goto fail ;
503
505
}
504
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
505
- "Arg %d (%s) is not a %s flag." ,
506
+ RCUTILS_LOG_DEBUG_NAMED (
507
+ ROS_PACKAGE_NAME , "Arg %d (%s) is not a %s flag." ,
506
508
i , argv [i ], RCL_LOG_LEVEL_FLAG );
507
509
508
510
// Attempt to parse argument as log configuration file
509
511
if (strcmp (RCL_EXTERNAL_LOG_CONFIG_FLAG , argv [i ]) == 0 ) {
510
512
if (i + 1 < argc ) {
511
513
if (NULL != args_impl -> external_log_config_file ) {
512
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
513
- "Overriding log configuration file : %s\n" ,
514
+ RCUTILS_LOG_DEBUG_NAMED (
515
+ ROS_PACKAGE_NAME , "Overriding log configuration file : %s\n" ,
514
516
args_impl -> external_log_config_file );
515
517
allocator .deallocate (args_impl -> external_log_config_file , allocator .state );
516
518
args_impl -> external_log_config_file = NULL ;
517
519
}
518
520
if (RCL_RET_OK == _rcl_parse_external_log_config_file (
519
521
argv [i + 1 ], allocator , & args_impl -> external_log_config_file ))
520
522
{
521
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
522
- "Got log configuration file : %s\n" ,
523
+ RCUTILS_LOG_DEBUG_NAMED (
524
+ ROS_PACKAGE_NAME , "Got log configuration file : %s\n" ,
523
525
args_impl -> external_log_config_file );
524
526
++ i ; // Skip flag here, for loop will skip value.
525
527
continue ;
@@ -536,19 +538,21 @@ rcl_parse_arguments(
536
538
ret = RCL_RET_INVALID_ROS_ARGS ;
537
539
goto fail ;
538
540
}
539
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
540
- "Arg %d (%s) is not a %s flag." ,
541
+ RCUTILS_LOG_DEBUG_NAMED (
542
+ ROS_PACKAGE_NAME , "Arg %d (%s) is not a %s flag." ,
541
543
i , argv [i ], RCL_EXTERNAL_LOG_CONFIG_FLAG );
542
544
543
545
// Attempt to parse --enable/disable-stdout-logs flag
544
546
ret = _rcl_parse_disabling_flag (
545
547
argv [i ], RCL_LOG_STDOUT_FLAG_SUFFIX , & args_impl -> log_stdout_disabled );
546
548
if (RCL_RET_OK == ret ) {
547
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
548
- "Disable log stdout ? %s\n" , args_impl -> log_stdout_disabled ? "true" : "false" );
549
+ RCUTILS_LOG_DEBUG_NAMED (
550
+ ROS_PACKAGE_NAME , "Disable log stdout ? %s\n" ,
551
+ args_impl -> log_stdout_disabled ? "true" : "false" );
549
552
continue ;
550
553
}
551
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
554
+ RCUTILS_LOG_DEBUG_NAMED (
555
+ ROS_PACKAGE_NAME ,
552
556
"Couldn't parse arg %d (%s) as %s%s or %s%s flag. Error: %s" ,
553
557
i , argv [i ], RCL_ENABLE_FLAG_PREFIX , RCL_LOG_STDOUT_FLAG_SUFFIX ,
554
558
RCL_DISABLE_FLAG_PREFIX , RCL_LOG_STDOUT_FLAG_SUFFIX , rcl_get_error_string ().str );
@@ -558,11 +562,13 @@ rcl_parse_arguments(
558
562
ret = _rcl_parse_disabling_flag (
559
563
argv [i ], RCL_LOG_ROSOUT_FLAG_SUFFIX , & args_impl -> log_rosout_disabled );
560
564
if (RCL_RET_OK == ret ) {
561
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
562
- "Disable log rosout ? %s\n" , args_impl -> log_rosout_disabled ? "true" : "false" );
565
+ RCUTILS_LOG_DEBUG_NAMED (
566
+ ROS_PACKAGE_NAME , "Disable log rosout ? %s\n" ,
567
+ args_impl -> log_rosout_disabled ? "true" : "false" );
563
568
continue ;
564
569
}
565
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
570
+ RCUTILS_LOG_DEBUG_NAMED (
571
+ ROS_PACKAGE_NAME ,
566
572
"Couldn't parse arg %d (%s) as %s%s or %s%s flag. Error: %s" ,
567
573
i , argv [i ], RCL_ENABLE_FLAG_PREFIX , RCL_LOG_ROSOUT_FLAG_SUFFIX ,
568
574
RCL_DISABLE_FLAG_PREFIX , RCL_LOG_ROSOUT_FLAG_SUFFIX , rcl_get_error_string ().str );
@@ -572,11 +578,13 @@ rcl_parse_arguments(
572
578
ret = _rcl_parse_disabling_flag (
573
579
argv [i ], RCL_LOG_EXT_LIB_FLAG_SUFFIX , & args_impl -> log_ext_lib_disabled );
574
580
if (RCL_RET_OK == ret ) {
575
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
576
- "Disable log external lib ? %s\n" , args_impl -> log_ext_lib_disabled ? "true" : "false" );
581
+ RCUTILS_LOG_DEBUG_NAMED (
582
+ ROS_PACKAGE_NAME , "Disable log external lib ? %s\n" ,
583
+ args_impl -> log_ext_lib_disabled ? "true" : "false" );
577
584
continue ;
578
585
}
579
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
586
+ RCUTILS_LOG_DEBUG_NAMED (
587
+ ROS_PACKAGE_NAME ,
580
588
"Couldn't parse arg %d (%s) as %s%s or %s%s flag. Error: %s" ,
581
589
i , argv [i ], RCL_ENABLE_FLAG_PREFIX , RCL_LOG_EXT_LIB_FLAG_SUFFIX ,
582
590
RCL_DISABLE_FLAG_PREFIX , RCL_LOG_EXT_LIB_FLAG_SUFFIX , rcl_get_error_string ().str );
@@ -596,14 +604,16 @@ rcl_parse_arguments(
596
604
rcl_remap_t * rule = & (args_impl -> remap_rules [args_impl -> num_remap_rules ]);
597
605
* rule = rcl_get_zero_initialized_remap ();
598
606
if (RCL_RET_OK == _rcl_parse_remap_rule (argv [i ], allocator , rule )) {
599
- RCUTILS_LOG_WARN_NAMED (ROS_PACKAGE_NAME ,
607
+ RCUTILS_LOG_WARN_NAMED (
608
+ ROS_PACKAGE_NAME ,
600
609
"Found remap rule '%s'. This syntax is deprecated. Use '%s %s %s' instead." ,
601
610
argv [i ], RCL_ROS_ARGS_FLAG , RCL_REMAP_FLAG , argv [i ]);
602
611
RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME , "Got remap rule : %s\n" , argv [i + 1 ]);
603
612
++ (args_impl -> num_remap_rules );
604
613
continue ;
605
614
}
606
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
615
+ RCUTILS_LOG_DEBUG_NAMED (
616
+ ROS_PACKAGE_NAME ,
607
617
"Couldn't parse arg %d (%s) as a remap rule in its deprecated form. Error: %s" ,
608
618
i , argv [i ], rcl_get_error_string ().str );
609
619
rcl_reset_error ();
@@ -616,31 +626,36 @@ rcl_parse_arguments(
616
626
& args_impl -> parameter_files [args_impl -> num_param_files_args ]))
617
627
{
618
628
++ (args_impl -> num_param_files_args );
619
- RCUTILS_LOG_WARN_NAMED (ROS_PACKAGE_NAME ,
629
+ RCUTILS_LOG_WARN_NAMED (
630
+ ROS_PACKAGE_NAME ,
620
631
"Found parameter file rule '%s'. This syntax is deprecated. Use '%s %s %s' instead." ,
621
632
argv [i ], RCL_ROS_ARGS_FLAG , RCL_PARAM_FILE_FLAG ,
622
633
args_impl -> parameter_files [args_impl -> num_param_files_args - 1 ]);
623
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
634
+ RCUTILS_LOG_DEBUG_NAMED (
635
+ ROS_PACKAGE_NAME ,
624
636
"params rule : %s\n total num param rules %d" ,
625
637
args_impl -> parameter_files [args_impl -> num_param_files_args - 1 ],
626
638
args_impl -> num_param_files_args );
627
639
continue ;
628
640
}
629
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
641
+ RCUTILS_LOG_DEBUG_NAMED (
642
+ ROS_PACKAGE_NAME ,
630
643
"Couldn't parse arg %d (%s) as a deprecated parameter file rule. Error: %s" ,
631
644
i , argv [i ], rcl_get_error_string ().str );
632
645
rcl_reset_error ();
633
646
634
647
// Attempt to parse argument as log level configuration
635
648
int log_level ;
636
649
if (RCL_RET_OK == _rcl_parse_log_level_rule (argv [i ], allocator , & log_level )) {
637
- RCUTILS_LOG_WARN_NAMED (ROS_PACKAGE_NAME ,
650
+ RCUTILS_LOG_WARN_NAMED (
651
+ ROS_PACKAGE_NAME ,
638
652
"Found log level rule '%s'. This syntax is deprecated. Use '%s %s %s' instead." ,
639
653
argv [i ], RCL_ROS_ARGS_FLAG , RCL_LOG_LEVEL_FLAG , g_rcutils_log_severity_names [log_level ]);
640
654
args_impl -> log_level = log_level ;
641
655
continue ;
642
656
}
643
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
657
+ RCUTILS_LOG_DEBUG_NAMED (
658
+ ROS_PACKAGE_NAME ,
644
659
"Couldn't parse arg %d (%s) as a deprecated log level rule. Error: %s" ,
645
660
i , argv [i ], rcl_get_error_string ().str );
646
661
rcl_reset_error ();
@@ -649,16 +664,18 @@ rcl_parse_arguments(
649
664
rcl_ret_t ret = _rcl_parse_external_log_config_file_rule (
650
665
argv [i ], allocator , & args_impl -> external_log_config_file );
651
666
if (RCL_RET_OK == ret ) {
652
- RCUTILS_LOG_WARN_NAMED (ROS_PACKAGE_NAME ,
667
+ RCUTILS_LOG_WARN_NAMED (
668
+ ROS_PACKAGE_NAME ,
653
669
"Found log config rule '%s'. This syntax is deprecated. Use '%s %s %s' instead." ,
654
670
argv [i ], RCL_ROS_ARGS_FLAG , RCL_EXTERNAL_LOG_CONFIG_FLAG ,
655
671
args_impl -> external_log_config_file );
656
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
657
- "Got log configuration file : %s\n" ,
672
+ RCUTILS_LOG_DEBUG_NAMED (
673
+ ROS_PACKAGE_NAME , "Got log configuration file : %s\n" ,
658
674
args_impl -> external_log_config_file );
659
675
continue ;
660
676
}
661
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
677
+ RCUTILS_LOG_DEBUG_NAMED (
678
+ ROS_PACKAGE_NAME ,
662
679
"Couldn't parse arg %d (%s) as a deprecated log config rule. Error: %s" ,
663
680
i , argv [i ], rcl_get_error_string ().str );
664
681
rcl_reset_error ();
@@ -669,14 +686,17 @@ rcl_parse_arguments(
669
686
if (RCL_RET_OK == ret ) {
670
687
const char * flag_prefix =
671
688
args_impl -> log_stdout_disabled ? RCL_DISABLE_FLAG_PREFIX : RCL_ENABLE_FLAG_PREFIX ;
672
- RCUTILS_LOG_WARN_NAMED (ROS_PACKAGE_NAME ,
689
+ RCUTILS_LOG_WARN_NAMED (
690
+ ROS_PACKAGE_NAME ,
673
691
"Found '%s'. This syntax is deprecated. Use '%s %s%s' instead." ,
674
692
argv [i ], RCL_ROS_ARGS_FLAG , flag_prefix , RCL_LOG_STDOUT_FLAG_SUFFIX );
675
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
676
- "Disable log stdout ? %s\n" , args_impl -> log_stdout_disabled ? "true" : "false" );
693
+ RCUTILS_LOG_DEBUG_NAMED (
694
+ ROS_PACKAGE_NAME , "Disable log stdout ? %s\n" ,
695
+ args_impl -> log_stdout_disabled ? "true" : "false" );
677
696
continue ;
678
697
}
679
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
698
+ RCUTILS_LOG_DEBUG_NAMED (
699
+ ROS_PACKAGE_NAME ,
680
700
"Couldn't parse arg %d (%s) as a deprecated log_stdout_disabled rule. Error: %s" ,
681
701
i , argv [i ], rcl_get_error_string ().str );
682
702
rcl_reset_error ();
@@ -687,14 +707,17 @@ rcl_parse_arguments(
687
707
if (RCL_RET_OK == ret ) {
688
708
const char * flag_prefix =
689
709
args_impl -> log_rosout_disabled ? RCL_DISABLE_FLAG_PREFIX : RCL_ENABLE_FLAG_PREFIX ;
690
- RCUTILS_LOG_WARN_NAMED (ROS_PACKAGE_NAME ,
710
+ RCUTILS_LOG_WARN_NAMED (
711
+ ROS_PACKAGE_NAME ,
691
712
"Found '%s'. This syntax is deprecated. Use '%s %s%s' instead." ,
692
713
argv [i ], RCL_ROS_ARGS_FLAG , flag_prefix , RCL_LOG_ROSOUT_FLAG_SUFFIX );
693
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
694
- "Disable log rosout ? %s\n" , args_impl -> log_rosout_disabled ? "true" : "false" );
714
+ RCUTILS_LOG_DEBUG_NAMED (
715
+ ROS_PACKAGE_NAME , "Disable log rosout ? %s\n" ,
716
+ args_impl -> log_rosout_disabled ? "true" : "false" );
695
717
continue ;
696
718
}
697
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
719
+ RCUTILS_LOG_DEBUG_NAMED (
720
+ ROS_PACKAGE_NAME ,
698
721
"Couldn't parse arg %d (%s) as a deprecated log_rosout_disabled rule. Error: %s" ,
699
722
i , argv [i ], rcl_get_error_string ().str );
700
723
rcl_reset_error ();
@@ -705,14 +728,17 @@ rcl_parse_arguments(
705
728
if (RCL_RET_OK == ret ) {
706
729
const char * flag_prefix =
707
730
args_impl -> log_ext_lib_disabled ? RCL_DISABLE_FLAG_PREFIX : RCL_ENABLE_FLAG_PREFIX ;
708
- RCUTILS_LOG_WARN_NAMED (ROS_PACKAGE_NAME ,
731
+ RCUTILS_LOG_WARN_NAMED (
732
+ ROS_PACKAGE_NAME ,
709
733
"Found '%s'. This syntax is deprecated. Use '%s %s%s' instead." ,
710
734
argv [i ], RCL_ROS_ARGS_FLAG , flag_prefix , RCL_LOG_EXT_LIB_FLAG_SUFFIX );
711
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
712
- "Disable log external lib ? %s\n" , args_impl -> log_ext_lib_disabled ? "true" : "false" );
735
+ RCUTILS_LOG_DEBUG_NAMED (
736
+ ROS_PACKAGE_NAME , "Disable log external lib ? %s\n" ,
737
+ args_impl -> log_ext_lib_disabled ? "true" : "false" );
713
738
continue ;
714
739
}
715
- RCUTILS_LOG_DEBUG_NAMED (ROS_PACKAGE_NAME ,
740
+ RCUTILS_LOG_DEBUG_NAMED (
741
+ ROS_PACKAGE_NAME ,
716
742
"Couldn't parse arg %d (%s) as a deprecated log_ext_lib_disabled rule. Error: %s" ,
717
743
i , argv [i ], rcl_get_error_string ().str );
718
744
rcl_reset_error ();
0 commit comments