Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic monitoring and status #19

Closed
tim77 opened this issue Apr 13, 2020 · 8 comments
Closed

Add basic monitoring and status #19

tim77 opened this issue Apr 13, 2020 · 8 comments
Labels
enhancement New feature or request
Milestone

Comments

@tim77
Copy link
Contributor

tim77 commented Apr 13, 2020

Would be nice to add some basic monitoring and status how much ram compressed and compression ratio.

@xvitaly xvitaly added this to the 0.3-release milestone Apr 13, 2020
@xvitaly xvitaly added the enhancement New feature or request label Apr 13, 2020
@hakavlad
Copy link
Contributor

hakavlad commented Apr 14, 2020

What it can monitor:

enabled                    Y
max_pool_percent           60
compressor                 lzo
zpool                      z3fold
same_filled_pages_enabled  Y
accept_threhsold_percent   50

same_filled_pages       0
stored_pages            0
pool_total_size         0
duplicate_entry         0
written_back_pages      0
reject_compress_poor    0
reject_kmemcache_fail   0
reject_alloc_fail       0
reject_reclaim_fail     0
pool_limit_hit          0

@hakavlad
Copy link
Contributor

# zswap-cli --stats
Duplicate entries count: 0.
Pool limit hit: 0.
Pool total size: 0.
Reject allocation failures: 0.
Reject compression poor: 0.
Reject Kmemcache failures: 0.
Reject reclaim failures: 0.
Same filled pages count: 0.
Stored pages count: 0.
Written back pages count: 0.

This is not what I need.

@hakavlad
Copy link
Contributor

I'd like to see:

enabled                    Y
max_pool_percent           60
compressor                 lzo
zpool                      z3fold
same_filled_pages_enabled  Y
accept_threhsold_percent   50

@hakavlad
Copy link
Contributor

And:
pool_total_size in MiBs
stored_pages in MiBs

@hakavlad
Copy link
Contributor

And
pool_total_size / MemTotal

@hakavlad
Copy link
Contributor

And pool_total_size / stored_pages

@hakavlad
Copy link
Contributor

Note that pool_total_size is in bytes.

@hakavlad
Copy link
Contributor

hakavlad commented Apr 16, 2020

pool_total_size: 300 MiB (5% MemTotal)
stored_pages: 600 MiB
Compression ratio: 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants