Cleanup Identity (#1734)

* Cleanup Identity

* changelogs, version bump

Author: codabrink

bindings_node/CHANGELOG.md

@@ -1,5 +1,9 @@
 # @xmtp/node-bindings
 
+## 1.0.0-rc2
+
+- Removed an optional `relying_party` field in the `Identifier` struct
+
 ## 1.0.0-rc1
 
 - Added `pausedForVersion` to groups for client enforcement

bindings_node/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xmtp/node-bindings",
-  "version": "1.0.0-rc1",
+  "version": "1.0.0-rc2",
   "repository": {
     "type": "git",
     "url": "git+https://git@github.com/xmtp/libxmtp.git",

bindings_node/src/identity.rs

@@ -8,7 +8,6 @@ use xmtp_id::associations::{ident, Identifier as XmtpIdentifier};
 pub struct Identifier {
   pub identifier: String,
   pub identifier_kind: IdentifierKind,
-  pub relying_party: Option<String>,
 }
 
 #[napi]
@@ -25,12 +24,10 @@ impl From<XmtpIdentifier> for Identifier {
       XmtpIdentifier::Ethereum(ident::Ethereum(addr)) => Self {
         identifier: addr,
         identifier_kind: IdentifierKind::Ethereum,
-        relying_party: None,
       },
-      XmtpIdentifier::Passkey(ident::Passkey { key, relying_party }) => Self {
+      XmtpIdentifier::Passkey(ident::Passkey { key, .. }) => Self {
         identifier: hex::encode(key),
         identifier_kind: IdentifierKind::Passkey,
-        relying_party,
       },
     }
   }
@@ -41,7 +38,7 @@ impl TryFrom<Identifier> for XmtpIdentifier {
   fn try_from(ident: Identifier) -> Result<Self, Self::Error> {
     let ident = match ident.identifier_kind {
       IdentifierKind::Ethereum => Self::eth(ident.identifier)?,
-      IdentifierKind::Passkey => Self::passkey_str(&ident.identifier, ident.relying_party)?,
+      IdentifierKind::Passkey => Self::passkey_str(&ident.identifier, None)?,
     };
     Ok(ident)
   }

bindings_wasm/CHANGELOG.md

@@ -1,5 +1,9 @@
 # @xmtp/wasm-bindings
 
+## 1.0.0-rc3
+
+- Removed an optional `relying_party` field in the `Identifier` struct
+
 ## 1.0.0-rc2
 
 - Updated some WASM aliases to remove references to addresses

bindings_wasm/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xmtp/wasm-bindings",
-  "version": "1.0.0-rc2",
+  "version": "1.0.0-rc3",
   "type": "module",
   "license": "MIT",
   "description": "WASM bindings for the libXMTP rust library",

bindings_wasm/src/identity.rs

@@ -8,8 +8,6 @@ pub struct Identifier {
   pub identifier: String,
   #[wasm_bindgen(js_name = identifierKind)]
   pub identifier_kind: IdentifierKind,
-  #[wasm_bindgen(js_name = relyingParty)]
-  pub relying_party: Option<String>,
 }
 
 #[wasm_bindgen]
@@ -18,12 +16,10 @@ impl Identifier {
   pub fn new(
     identifier: String,
     #[wasm_bindgen(js_name = identifierKind)] identifier_kind: IdentifierKind,
-    #[wasm_bindgen(js_name = relyingParty)] relying_party: Option<String>,
   ) -> Self {
     Self {
       identifier,
       identifier_kind,
-      relying_party,
     }
   }
 }
@@ -41,12 +37,10 @@ impl From<XmtpIdentifier> for Identifier {
       XmtpIdentifier::Ethereum(ident::Ethereum(addr)) => Self {
         identifier: addr,
         identifier_kind: IdentifierKind::Ethereum,
-        relying_party: None,
       },
-      XmtpIdentifier::Passkey(ident::Passkey { key, relying_party }) => Self {
+      XmtpIdentifier::Passkey(ident::Passkey { key, .. }) => Self {
         identifier: hex::encode(key),
         identifier_kind: IdentifierKind::Passkey,
-        relying_party,
       },
     }
   }
@@ -57,7 +51,7 @@ impl TryFrom<Identifier> for XmtpIdentifier {
   fn try_from(ident: Identifier) -> Result<Self, Self::Error> {
     let ident = match ident.identifier_kind {
       IdentifierKind::Ethereum => Self::eth(ident.identifier)?,
-      IdentifierKind::Passkey => Self::passkey_str(&ident.identifier, ident.relying_party)?,
+      IdentifierKind::Passkey => Self::passkey_str(&ident.identifier, None)?,
     };
     Ok(ident)
   }