Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bench: development tracking branch for benchmarking #4008

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

EdmundGoodman
Copy link
Collaborator

A draft PR to track the ongoing development of xDSL benchmarking. This branch is not intended to be merged, but instead to provide visibility. Benchmarks will be merged to the main branch in small increments in separate PRs.

@EdmundGoodman EdmundGoodman added the bench Benchmark related changes label Mar 3, 2025
@EdmundGoodman EdmundGoodman requested a review from superlopuh March 3, 2025 12:33
@EdmundGoodman EdmundGoodman self-assigned this Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 542 lines in your changes missing coverage. Please review.

Project coverage is 89.35%. Comparing base (3d4d51d) to head (91d0630).

Files with missing lines Patch % Lines
benchmarks/bench_utils.py 0.00% 125 Missing ⚠️
benchmarks/imports.py 0.00% 76 Missing ⚠️
benchmarks/visualisations.py 0.00% 70 Missing ⚠️
benchmarks/end_to_end.py 0.00% 68 Missing ⚠️
benchmarks/microbenchmarks.py 0.00% 48 Missing ⚠️
benchmarks/lexer.py 0.00% 40 Missing ⚠️
benchmarks/rewriting.py 0.00% 39 Missing ⚠️
benchmarks/parser.py 0.00% 23 Missing ⚠️
benchmarks/printer.py 0.00% 22 Missing ⚠️
benchmarks/verifier.py 0.00% 19 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4008      +/-   ##
==========================================
- Coverage   90.17%   89.35%   -0.82%     
==========================================
  Files         458      468      +10     
  Lines       58304    58838     +534     
  Branches     5694     5740      +46     
==========================================
  Hits        52573    52573              
- Misses       4339     4873     +534     
  Partials     1392     1392              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first to merge?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compor compor self-requested a review March 4, 2025 10:17
superlopuh pushed a commit that referenced this pull request Mar 4, 2025
Add gitignore file for profile outputs in response to
[comment](#4008 (comment))
@@ -28,12 +28,12 @@
"uninstall_command": ["return-code=any python -mpip uninstall -y {project}"],
"build_command": [
"python setup.py build",
"PIP_NO_BUILD_ISOLATION=false python -m pip wheel --no-deps --no-index -w {build_cache_dir} {build_dir}"
"PIP_NO_BUILD_ISOLATION=false python -mpip wheel --no-deps --no-index -w {build_cache_dir} {build_dir}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does -mpip do vs -m pip?

@compor compor changed the title bench: development tracking branch for benchmarking [WIP] bench: development tracking branch for benchmarking Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bench Benchmark related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants