Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interactive: minor type fix in get_pass_argument_names_and_types() in passes.py #1845

Closed
dshaaban01 opened this issue Dec 8, 2023 · 0 comments · Fixed by #4032
Closed

interactive: minor type fix in get_pass_argument_names_and_types() in passes.py #1845

dshaaban01 opened this issue Dec 8, 2023 · 0 comments · Fixed by #4032
Assignees
@superlopuh @dshaaban01
Labels
interactive xdsl-gui things

Comments

@dshaaban01
Copy link
Collaborator

get_pass_argument_names_and_types() function in passes.py takes a ModulePassT and outputs a string containing the names of the pass arguments and their types. For Literal's, we would like it to output the actual type instead of its element. e.g. for the attribute declaration literal:literal : Literal["yes", "no", "maybe"] = "no", the function currently outputs literal=no, but we would like to instead output the string literal=Literal["no"], as no is not a type, while Literal["no"] is.
@dshaaban01 dshaaban01 added the interactive xdsl-gui things label Dec 8, 2023
@dshaaban01 dshaaban01 mentioned this issue Dec 8, 2023
Merged
superlopuh added a commit that referenced this issue Mar 6, 2025
@superlopuh
interactive: return structured tuple in get_pass_argument_names_and_t…
c2e617a 
…ypes

We currently return a string, which doesn't allow the caller to choose whether and how to display the options.
Plenty of work to do still when the interactive project picks back up, but I feel like it's a step in the right direction.

Fixes #1845
@superlopuh superlopuh mentioned this issue Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@superlopuh superlopuh

@dshaaban01 dshaaban01

Labels
interactive xdsl-gui things
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

interactive: return structured tuple in get_pass_argument_names_and_types xdslproject/xdsl
2 participants
@superlopuh @dshaaban01