fix: Jobn execution now checks project membership

Author: Alan Christie

viewer/squonk2_agent.py

@@ -746,11 +746,11 @@ def _verify_access(self, c_params: CommonParams) -> Squonk2AgentRv:
         target_access_string = self._get_target_access_string(access_id)
         assert target_access_string
         proposal_list: List[str] = self.__ispyb_safe_query_set.get_proposals_for_user(
-            user
+            user, restrict_to_membership=True
         )
         if not target_access_string in proposal_list:
             msg = (
-                f'The user ({user.username}) cannot access "{target_access_string}"'
+                f'The user ({user.username}) cannot modify "{target_access_string}"'
                 f' (access_id={access_id}). Only {proposal_list})'
             )
             _LOGGER.warning(msg)

viewer/views.py

@@ -1561,7 +1561,7 @@ def create(self, request, *args, **kwargs):
                                 f"You are not authorized to upload data to {target_access_string}"
                             ]
                         },
-                        status=status.HTTP_400_BAD_REQUEST,
+                        status=status.HTTP_403_FORBIDDEN,
                     )
 
         # memo to self: cannot use TemporaryDirectory here because task