Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

Commit f829cb4

Browse files
krzkgregkh
authored andcommitted
clk: bcm: bcm53573: fix OF node leak in init
[ Upstream commit f92d67e ] Driver code is leaking OF node reference from of_get_parent() in bcm53573_ilp_init(). Usage of of_get_parent() is not needed in the first place, because the parent node will not be freed while we are processing given node (triggered by CLK_OF_DECLARE()). Thus fix the leak by accessing parent directly, instead of of_get_parent(). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20240826065801.17081-1-krzysztof.kozlowski@linaro.org Signed-off-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent ccb8e44 commit f829cb4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/clk/bcm/clk-bcm53573-ilp.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ static void bcm53573_ilp_init(struct device_node *np)
112112
goto err_free_ilp;
113113
}
114114

115-
ilp->regmap = syscon_node_to_regmap(of_get_parent(np));
115+
ilp->regmap = syscon_node_to_regmap(np->parent);
116116
if (IS_ERR(ilp->regmap)) {
117117
err = PTR_ERR(ilp->regmap);
118118
goto err_free_ilp;

0 commit comments

Comments
 (0)