Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

Commit ccea29b

Browse files
t-8chgregkh
authored andcommitted
s390/sclp: Deactivate sclp after all its users
commit 0d9dc27 upstream. On reboot the SCLP interface is deactivated through a reboot notifier. This happens before other components using SCLP have the chance to run their own reboot notifiers. Two of those components are the SCLP console and tty drivers which try to flush the last outstanding messages. At that point the SCLP interface is already unusable and the messages are discarded. Execute sclp_deactivate() as late as possible to avoid this issue. Fixes: 4ae46db ("s390/consoles: improve panic notifiers reliability") Cc: stable@vger.kernel.org Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Reviewed-by: Sven Schnelle <svens@linux.ibm.com> Link: https://lore.kernel.org/r/20241014-s390-kunit-v1-1-941defa765a6@linutronix.de Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent fe2e0b6 commit ccea29b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/s390/char/sclp.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -1195,7 +1195,8 @@ sclp_reboot_event(struct notifier_block *this, unsigned long event, void *ptr)
11951195
}
11961196

11971197
static struct notifier_block sclp_reboot_notifier = {
1198-
.notifier_call = sclp_reboot_event
1198+
.notifier_call = sclp_reboot_event,
1199+
.priority = INT_MIN,
11991200
};
12001201

12011202
static ssize_t con_pages_show(struct device_driver *dev, char *buf)

0 commit comments

Comments
 (0)