Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

Commit c076b37

Browse files
Zhao Mengmenggregkh
Zhao Mengmeng
authored andcommitted
jfs: Fix uninit-value access of new_ea in ea_buffer
[ Upstream commit 2b59ffa ] syzbot reports that lzo1x_1_do_compress is using uninit-value: ===================================================== BUG: KMSAN: uninit-value in lzo1x_1_do_compress+0x19f9/0x2510 lib/lzo/lzo1x_compress.c:178 ... Uninit was stored to memory at: ea_put fs/jfs/xattr.c:639 [inline] ... Local variable ea_buf created at: __jfs_setxattr+0x5d/0x1ae0 fs/jfs/xattr.c:662 __jfs_xattr_set+0xe6/0x1f0 fs/jfs/xattr.c:934 ===================================================== The reason is ea_buf->new_ea is not initialized properly. Fix this by using memset to empty its content at the beginning in ea_get(). Reported-by: syzbot+02341e0daa42a15ce130@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=02341e0daa42a15ce130 Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 9288a96 commit c076b37

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

fs/jfs/xattr.c

+2
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,8 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size)
434434
int rc;
435435
int quota_allocation = 0;
436436

437+
memset(&ea_buf->new_ea, 0, sizeof(ea_buf->new_ea));
438+
437439
/* When fsck.jfs clears a bad ea, it doesn't clear the size */
438440
if (ji->ea.flag == 0)
439441
ea_size = 0;

0 commit comments

Comments
 (0)