Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

Commit 58f31be

Browse files
Junlin Ligregkh
Junlin Li
authored andcommitted
drivers: media: dvb-frontends/rtl2830: fix an out-of-bounds write error
[ Upstream commit 46d7ebf ] Ensure index in rtl2830_pid_filter does not exceed 31 to prevent out-of-bounds access. dev->filters is a 32-bit value, so set_bit and clear_bit functions should only operate on indices from 0 to 31. If index is 32, it will attempt to access a non-existent 33rd bit, leading to out-of-bounds access. Change the boundary check from index > 32 to index >= 32 to resolve this issue. Fixes: df70dda ("[media] rtl2830: implement PID filter") Signed-off-by: Junlin Li <make24@iscas.ac.cn> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 527ab3e commit 58f31be

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/media/dvb-frontends/rtl2830.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ static int rtl2830_pid_filter(struct dvb_frontend *fe, u8 index, u16 pid, int on
609609
index, pid, onoff);
610610

611611
/* skip invalid PIDs (0x2000) */
612-
if (pid > 0x1fff || index > 32)
612+
if (pid > 0x1fff || index >= 32)
613613
return 0;
614614

615615
if (onoff)

0 commit comments

Comments
 (0)