Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

Commit 529689a

Browse files
Jinjie Ruangregkh
Jinjie Ruan
authored andcommitted
net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request_irq()
[ Upstream commit 09573b1 ] disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 8c6ad9c ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> Link: https://lore.kernel.org/20240911094234.1922418-1-ruanjinjie@huawei.com Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 5ee4c0d commit 529689a

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

drivers/net/ieee802154/mcr20a.c

+1-4
Original file line numberDiff line numberDiff line change
@@ -1302,16 +1302,13 @@ mcr20a_probe(struct spi_device *spi)
13021302
irq_type = IRQF_TRIGGER_FALLING;
13031303

13041304
ret = devm_request_irq(&spi->dev, spi->irq, mcr20a_irq_isr,
1305-
irq_type, dev_name(&spi->dev), lp);
1305+
irq_type | IRQF_NO_AUTOEN, dev_name(&spi->dev), lp);
13061306
if (ret) {
13071307
dev_err(&spi->dev, "could not request_irq for mcr20a\n");
13081308
ret = -ENODEV;
13091309
goto free_dev;
13101310
}
13111311

1312-
/* disable_irq by default and wait for starting hardware */
1313-
disable_irq(spi->irq);
1314-
13151312
ret = ieee802154_register_hw(hw);
13161313
if (ret) {
13171314
dev_crit(&spi->dev, "ieee802154_register_hw failed\n");

0 commit comments

Comments
 (0)