Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

Commit 0e25b68

Browse files
efzrhgregkh
authored andcommitted
rtla: Fix the help text in osnoise and timerlat top tools
commit 3d7b8ea upstream. The help text in osnoise top and timerlat top had some minor errors and omissions. The -d option was missing the 's' (second) abbreviation and the error message for '-d' used '-D'. Cc: stable@vger.kernel.org Fixes: 1eceb2f ("rtla/osnoise: Add osnoise top mode") Fixes: a828cd1 ("rtla: Add timerlat tool and timelart top mode") Link: https://lore.kernel.org/20240813155831.384446-1-ezulian@redhat.com Suggested-by: Tomas Glozar <tglozar@redhat.com> Reviewed-by: Tomas Glozar <tglozar@redhat.com> Signed-off-by: Eder Zulian <ezulian@redhat.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 37acf0e commit 0e25b68

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

tools/tracing/rtla/src/osnoise_top.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ struct osnoise_top_params *osnoise_top_parse_args(int argc, char **argv)
442442
case 'd':
443443
params->duration = parse_seconds_duration(optarg);
444444
if (!params->duration)
445-
osnoise_top_usage(params, "Invalid -D duration\n");
445+
osnoise_top_usage(params, "Invalid -d duration\n");
446446
break;
447447
case 'e':
448448
tevent = trace_event_alloc(optarg);

tools/tracing/rtla/src/timerlat_top.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ static void timerlat_top_usage(char *usage)
459459
" -c/--cpus cpus: run the tracer only on the given cpus",
460460
" -H/--house-keeping cpus: run rtla control threads only on the given cpus",
461461
" -C/--cgroup[=cgroup_name]: set cgroup, if no cgroup_name is passed, the rtla's cgroup will be inherited",
462-
" -d/--duration time[m|h|d]: duration of the session in seconds",
462+
" -d/--duration time[s|m|h|d]: duration of the session",
463463
" -D/--debug: print debug info",
464464
" --dump-tasks: prints the task running on all CPUs if stop conditions are met (depends on !--no-aa)",
465465
" -t/--trace[file]: save the stopped trace to [file|timerlat_trace.txt]",
@@ -613,7 +613,7 @@ static struct timerlat_top_params
613613
case 'd':
614614
params->duration = parse_seconds_duration(optarg);
615615
if (!params->duration)
616-
timerlat_top_usage("Invalid -D duration\n");
616+
timerlat_top_usage("Invalid -d duration\n");
617617
break;
618618
case 'e':
619619
tevent = trace_event_alloc(optarg);

0 commit comments

Comments
 (0)