-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Image and text alignment / spacing is incorrect #5160
Comments
I am having a look at this and I just want to mention that the Material and non-Material should not be exactly the same. We have taken the opportunity with Material to fix several layout/calculation errors that would otherwise be a breaking change for the existing visual. The aim of Material is that the values set would result in (almost) exactly the same result on both iOS and Android. |
@mattleibow I am aware the look is not supposed to be identical, just wanted to provide as much information as possible. |
Ah, thanks! Just creating a sample app now to see what I can get. |
Unless I missed something only the iOS layout issues were fixed. Should I create a separate issue for the Android spacing problems? https://i.imgur.com/27QerB4.png |
@pikausp Yes, please! That'll help us track it better. Thanks! |
@pikausp wrote on #4967 (comment):
Hey,
first of all, thanks for the PR! [#4967] I installed the latest preview and there are some things that are not behaving correctly (or so I believe at least).
ImagePosition
isTop
is now broken on iOSBefore https://i.imgur.com/yPJvFup.png
After https://i.imgur.com/0BiNAdL.png
I cannot verify this on a physical device right now, so I do hope it's not just a weird emulator bug.
4.0-pre4 + Material Visual https://i.imgur.com/HHxXmS5.png
4.0-pre4 + Without Visual https://i.imgur.com/EYefWcN.png
3.5-rc1 + Material Visual https://i.imgur.com/O6ioHCM.png
3.5-rc1 + Without Visual https://i.imgur.com/dRBNy7J.png
A workaround is to set negative spacing in
ContentLayout
i.eContentLayout="Top, -40"
.The text was updated successfully, but these errors were encountered: