Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[Internal] AndroidDeviceInfo is setting ScaledScreenSize with Width for Height #1579

Closed
adrianknight89 opened this issue Jan 14, 2018 · 4 comments · Fixed by #3641
Closed

Comments

@adrianknight89
Copy link
Contributor

Description

Here's the issue:

ScaledScreenSize = new Size(_pixelScreenSize.Width / _scalingFactor, _pixelScreenSize.Width / _scalingFactor);

When Size is being allocated, we're using Width for Height.

@adrianknight89 adrianknight89 changed the title [Android] AndroidDeviceInfo is setting ScaledScreenSize with Width for Height [Internal] AndroidDeviceInfo is setting ScaledScreenSize with Width for Height Jan 14, 2018
@samhouts samhouts added the e/1 🕐 1 label Jul 26, 2018
@adrianknight89
Copy link
Contributor Author

@rmarinho @hartez #3641 fixes this.

@rmarinho
Copy link
Member

Oh awesome thanks missed it.

@hartez
Copy link
Contributor

hartez commented Aug 27, 2018

Well, now I'm just sad that @adrianknight89 noticed this like 8 months ago, told us about it, and we somehow still missed it. :(

@adrianknight89
Copy link
Contributor Author

@hartez You guys have a lot on your plate, so I'm not surprised. Looks like it'll be tough to scour the current list of issues and mark duplicate items. Thanks for fixing this issue though. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants