Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent browser popup when Ctrl-S / Cmd-S triggered #447

Closed
festoney8 opened this issue Dec 1, 2024 · 2 comments · Fixed by #451
Closed

Prevent browser popup when Ctrl-S / Cmd-S triggered #447

festoney8 opened this issue Dec 1, 2024 · 2 comments · Fixed by #451
Labels
area:frontend Frontend-related task in-progress Status: In Progress

Comments

@festoney8
Copy link

Is your feature request related to a problem? Please describe.

Ctrl-S / Cmd-S will trigger a browser popup to save webpage, it's annoying, but it's hard to get out of that habit...

Describe the solution you'd like

  • Just prevent event when Ctrl-S / Cmd-S
  • Or change that shortcut to other function such as copy share url to clipboard, just like typescript playground
@x1unix
Copy link
Owner

x1unix commented Dec 1, 2024

@festoney8 please update the issue description if you would like to have a sharing snippet on save functionality.

Also, would you like to contribute on this feature?

@x1unix x1unix added the awaiting-feedback Requires feedback from one or other users label Dec 1, 2024
@festoney8
Copy link
Author

For me, simply preventing the popup is enough.

I tested Ctrl-S in several playgrounds while creating this issue and found that this operation, both in TypeScript playground and official Go playground, is related to sharing.
Perhaps this is a more common practice? So I included that option in the solution. It's up to your decision.

I'd like to contribute but unfortunately I'm not familiar with react.

@x1unix x1unix added in-progress Status: In Progress area:frontend Frontend-related task and removed awaiting-feedback Requires feedback from one or other users labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Frontend-related task in-progress Status: In Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants