Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some components don't forward refs #276

Closed
3 of 15 tasks
Tracked by #21415
brionmario opened this issue Oct 8, 2024 · 0 comments · Fixed by #281
Closed
3 of 15 tasks
Tracked by #21415

Some components don't forward refs #276

brionmario opened this issue Oct 8, 2024 · 0 comments · Fixed by #281
Assignees
@brionmario
Labels
bug Something isn't working hacktoberfest Issues dedicated for the annual annual Hacktoberfest open source festival. package:react Issues/PRs related to the `@oxygen-ui/react` package.

Comments

@brionmario
Copy link
Member

brionmario commented Oct 8, 2024 •
edited
Loading

Describe the issue:

There are some components that doesn't properly follow the composition guideline of MUI.

ref should be properly forwarded for the components to work in cases where the consumer tries to use refs.

How to reproduce:

  • See components like Accordion etc. where ref is not forwarded.

Expected behavior:

Wrapped components should pass refs.

Additional context :

  • Affected Package:
    • @oxygen-ui/logger
    • @oxygen-ui/primitives
    • @oxygen-ui/react
    • @oxygen-ui/react-icons
  • Library Version: 1.13.13
  • OS:
    • Windows
    • Linux
    • Mac
    • Other
  • Browser:
    • Google Chrome
    • Firefox
    • Safari
    • Microsoft Edge
    • Brave
    • Opera
    • Other
@brionmario brionmario added bug Something isn't working package:react Issues/PRs related to the `@oxygen-ui/react` package. hacktoberfest Issues dedicated for the annual annual Hacktoberfest open source festival. labels Oct 8, 2024
@brionmario brionmario self-assigned this Oct 8, 2024
@brionmario brionmario mentioned this issue Oct 10, 2024
Merged
9 tasks
@brionmario brionmario mentioned this issue Oct 21, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brionmario brionmario

Labels
bug Something isn't working hacktoberfest Issues dedicated for the annual annual Hacktoberfest open source festival. package:react Issues/PRs related to the `@oxygen-ui/react` package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(react): fix component composition issues brionmario/oxygen-ui
1 participant
@brionmario