Skip to content

Commit 8d6ecce

Browse files
committed
Added everything for Step 10: Implement “Lazy Loading”
1 parent 6419bb0 commit 8d6ecce

File tree

5 files changed

+30
-2
lines changed

5 files changed

+30
-2
lines changed

webapp/controller/employee/Resume.controller.js

+6
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,12 @@ sap.ui.define([
3333
oQuery = oArgs["?query"];
3434
if (oQuery && _aValidTabKeys.indexOf(oQuery.tab) > -1) {
3535
oView.getModel("view").setProperty("/selectedTabKey", oQuery.tab);
36+
// support lazy loading for the hobbies and notes tab
37+
if (oQuery.tab === "Hobbies" || oQuery.tab === "Notes"){
38+
// the target is either "resumeTabHobbies" or "resumeTabNotes"
39+
this.getRouter().getTargets().display("resumeTab" + oQuery.tab);
40+
}
41+
3642
} else {
3743
// the default query param should be visible at all time
3844
this.getRouter().navTo("employeeResume", {

webapp/manifest.json

+16
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,22 @@
142142
"viewName": "employee.Resume",
143143
"viewLevel": 4,
144144
"transition": "flip"
145+
},
146+
"resumeTabHobbies": {
147+
"viewId": "resumeHobbies",
148+
"parent": "employeeResume",
149+
"viewPath": "com.mrb.UI5-Navigation-and-Routing.view.employee",
150+
"viewName": "ResumeHobbies",
151+
"controlId": "hobbiesTab",
152+
"controlAggregation": "content"
153+
},
154+
"resumeTabNotes": {
155+
"viewId": "resumeNotes",
156+
"parent": "employeeResume",
157+
"viewPath": "com.mrb.UI5-Navigation-and-Routing.view.employee",
158+
"viewName": "ResumeNotes",
159+
"controlId": "notesTab",
160+
"controlAggregation": "content"
145161
}
146162
}
147163
}

webapp/view/employee/Resume.view.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
<mvc:XMLView viewName="com.mrb.UI5-Navigation-and-Routing.view.employee.ResumeProjects"></mvc:XMLView>
1313
</IconTabFilter>
1414
<IconTabFilter id="hobbiesTab" text="{i18n>tabHobbies}" key="Hobbies">
15-
<Text text="{Hobbies}"/>
15+
<!-- place content via lazy loading OLD: <Text text="{Hobbies}"/>-->
1616
</IconTabFilter>
1717
<IconTabFilter id="notesTab" text="{i18n>tabNotes}" key="Notes">
18-
<Text text="{Notes}"/>
18+
<!-- place content via lazy OLD: <Text text="{Notes}"/>-->
1919
</IconTabFilter>
2020
</items>
2121
</IconTabBar>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<mvc:View xmlns="sap.m" xmlns:mvc="sap.ui.core.mvc">
2+
<Text text="{Hobbies}"/>
3+
</mvc:View>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<mvc:View xmlns="sap.m" xmlns:mvc="sap.ui.core.mvc">
2+
<Text text="{Notes}"/>
3+
</mvc:View>

0 commit comments

Comments
 (0)