From 2477b633a4213c9a634b2d665232671190907795 Mon Sep 17 00:00:00 2001 From: Daniele Bogo Date: Thu, 5 Sep 2019 19:31:39 +0100 Subject: [PATCH 01/47] Fix revisions colors --- .../Models/DiffAbstractValue+Attributes.swift | 12 +++++---- .../Pages/PageListSectionHeaderView.swift | 3 +++ .../Diffs/RevisionDiffViewController.swift | 16 +++++++++--- .../RevisionPreviewViewController.swift | 1 + .../RevisionDiffsBrowserViewController.swift | 4 +++ .../Revisions/Browser/Revisions.storyboard | 25 ++++++++++--------- .../RevisionsTableViewController.swift | 1 + .../Views/Cell/RevisionsTableViewCell.swift | 3 +++ .../Footer/RevisionsTableViewFooter.swift | 2 +- .../RevisionOperationViewController.swift | 2 ++ 10 files changed, 47 insertions(+), 22 deletions(-) diff --git a/WordPress/Classes/Models/DiffAbstractValue+Attributes.swift b/WordPress/Classes/Models/DiffAbstractValue+Attributes.swift index 64b2e268298d..bd53953e8145 100644 --- a/WordPress/Classes/Models/DiffAbstractValue+Attributes.swift +++ b/WordPress/Classes/Models/DiffAbstractValue+Attributes.swift @@ -2,15 +2,17 @@ extension DiffAbstractValue { var attributes: [NSAttributedString.Key: Any]? { switch operation { case .add: - return [.backgroundColor: UIColor.muriel(color: MurielColor(name: .blue, shade: .shade5)), + return [.backgroundColor: UIColor(light: .muriel(color: MurielColor(name: .blue, shade: .shade5)), + dark: .primary(.shade80)), .underlineStyle: NSNumber(value: 2), - .underlineColor: UIColor.primary] + .underlineColor: UIColor(light: .primary, dark: .primary(.shade20))] case .del: - return [.backgroundColor: UIColor.muriel(color: MurielColor(name: .red, shade: .shade5)), + return [.backgroundColor: UIColor(light: .muriel(color: MurielColor(name: .red, shade: .shade5)), + dark: .muriel(color: MurielColor(name: .red, shade: .shade80))), .underlineStyle: NSNumber(value: 2), - .underlineColor: UIColor.error, + .underlineColor: UIColor(light: .error, dark: .muriel(color: MurielColor(name: .red, shade: .shade20))), .strikethroughStyle: NSNumber(value: 1), - .strikethroughColor: UIColor.black] + .strikethroughColor: UIColor.text] default: return nil } diff --git a/WordPress/Classes/ViewRelated/Pages/PageListSectionHeaderView.swift b/WordPress/Classes/ViewRelated/Pages/PageListSectionHeaderView.swift index 218ca6ef4819..688e5a2d43ea 100644 --- a/WordPress/Classes/ViewRelated/Pages/PageListSectionHeaderView.swift +++ b/WordPress/Classes/ViewRelated/Pages/PageListSectionHeaderView.swift @@ -11,6 +11,9 @@ class PageListSectionHeaderView: UIView { override func awakeFromNib() { super.awakeFromNib() + + backgroundColor = .listBackground + titleLabel.backgroundColor = .listBackground WPStyleGuide.applyBorderStyle(separator) } } diff --git a/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Diffs/RevisionDiffViewController.swift b/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Diffs/RevisionDiffViewController.swift index f4b039a52c04..e9fb2f77d7fb 100644 --- a/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Diffs/RevisionDiffViewController.swift +++ b/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Diffs/RevisionDiffViewController.swift @@ -5,15 +5,14 @@ class RevisionDiffViewController: UIViewController, StoryboardLoadable { @IBOutlet private var titleLabel: UILabel! @IBOutlet private var contentLabel: UILabel! + @IBOutlet private var scrollView: UIScrollView! var revision: Revision? override func viewDidLoad() { super.viewDidLoad() - - titleLabel.font = WPFontManager.notoBoldFont(ofSize: 24.0) - contentLabel.font = WPFontManager.notoRegularFont(ofSize: 16) + setupUI() } override func viewWillAppear(_ animated: Bool) { @@ -22,8 +21,17 @@ class RevisionDiffViewController: UIViewController, StoryboardLoadable { } } - private extension RevisionDiffViewController { + private func setupUI() { + view.backgroundColor = .basicBackground + scrollView.backgroundColor = .basicBackground + + titleLabel.font = WPFontManager.notoBoldFont(ofSize: 24.0) + contentLabel.font = WPFontManager.notoRegularFont(ofSize: 16) + titleLabel.textColor = .text + contentLabel.textColor = .text + } + private func showRevision() { guard let revision = revision else { return diff --git a/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Preview/RevisionPreviewViewController.swift b/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Preview/RevisionPreviewViewController.swift index 6d97f0bb4b84..8b5dc4c438e8 100644 --- a/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Preview/RevisionPreviewViewController.swift +++ b/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Preview/RevisionPreviewViewController.swift @@ -96,6 +96,7 @@ private extension RevisionPreviewViewController { // private extension RevisionPreviewViewController { private func addSubviews() { + view.backgroundColor = .basicBackground view.addSubview(textView) textView.addSubview(titleLabel) } diff --git a/WordPress/Classes/ViewRelated/Post/Revisions/Browser/RevisionDiffsBrowserViewController.swift b/WordPress/Classes/ViewRelated/Post/Revisions/Browser/RevisionDiffsBrowserViewController.swift index e85f203a2ce6..1ab542f6cb3a 100644 --- a/WordPress/Classes/ViewRelated/Post/Revisions/Browser/RevisionDiffsBrowserViewController.swift +++ b/WordPress/Classes/ViewRelated/Post/Revisions/Browser/RevisionDiffsBrowserViewController.swift @@ -12,6 +12,8 @@ class RevisionDiffsBrowserViewController: UIViewController { private var contentPreviewState: ContentPreviewState = .html @IBOutlet private var containerView: UIView! + @IBOutlet private var strokeView: UIView! + @IBOutlet private var revisionContainer: UIView! @IBOutlet private var revisionTitle: UILabel! @IBOutlet private var previousButton: UIButton! @IBOutlet private var nextButton: UIButton! @@ -143,6 +145,8 @@ private extension RevisionDiffsBrowserViewController { navigationItem.leftBarButtonItems = [doneBarButtonItem] navigationItem.rightBarButtonItems = [moreBarButtonItem, loadBarButtonItem] navigationItem.title = NSLocalizedString("Revision", comment: "Title of the screen that shows the revisions.") + strokeView.backgroundColor = .divider + revisionContainer.backgroundColor = .listForeground } private func updateNextPreviousButtons() { diff --git a/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Revisions.storyboard b/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Revisions.storyboard index 2aaccc6e88cb..b9bf3148048a 100644 --- a/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Revisions.storyboard +++ b/WordPress/Classes/ViewRelated/Post/Revisions/Browser/Revisions.storyboard @@ -1,11 +1,9 @@ - - - - + + - + @@ -16,7 +14,7 @@ - + @@ -32,11 +30,11 @@ - + - + @@ -52,4 +51,9 @@ + + + + + diff --git a/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistCell.swift b/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistCell.swift index 9779350bd90f..46174729f216 100644 --- a/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistCell.swift +++ b/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistCell.swift @@ -12,8 +12,16 @@ class QuickStartChecklistCell: UITableViewCell { } } @IBOutlet private var iconView: UIImageView? - @IBOutlet private var stroke: UIView? - @IBOutlet private var topSeparator: UIView? + @IBOutlet private var stroke: UIView? { + didSet { + stroke?.backgroundColor = .divider + } + } + @IBOutlet private var topSeparator: UIView? { + didSet { + topSeparator?.backgroundColor = .divider + } + } private var bottomStrokeLeading: NSLayoutConstraint? private var contentViewLeadingAnchor: NSLayoutXAxisAnchor { @@ -34,9 +42,11 @@ class QuickStartChecklistCell: UITableViewCell { attributes: [.strikethroughStyle: 1, .foregroundColor: UIColor.neutral(.shade30)]) descriptionLabel.textColor = .neutral(.shade30) + iconView?.tintColor = .neutral(.shade30) } else { - titleLabel.textColor = .neutral(.shade70) - descriptionLabel.textColor = .neutral(.shade70) + titleLabel.textColor = .text + descriptionLabel.textColor = .textSubtle + iconView?.tintColor = .listIcon } } } @@ -44,7 +54,7 @@ class QuickStartChecklistCell: UITableViewCell { didSet { titleLabel.text = tour?.title descriptionLabel.text = tour?.description - iconView?.image = tour?.icon.imageWithTintColor(.neutral(.shade20)) + iconView?.image = tour?.icon.withRenderingMode(.alwaysTemplate) if let hint = tour?.accessibilityHintText, !hint.isEmpty { accessibilityHint = hint @@ -67,6 +77,7 @@ class QuickStartChecklistCell: UITableViewCell { override func awakeFromNib() { super.awakeFromNib() + contentView.backgroundColor = .listForeground setupConstraints() } diff --git a/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistHeader.swift b/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistHeader.swift index b2607c8056ba..80d1a7d89a48 100644 --- a/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistHeader.swift +++ b/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistHeader.swift @@ -34,10 +34,19 @@ class QuickStartChecklistHeader: UIView { @IBOutlet private var chevronView: UIImageView! { didSet { chevronView.image = Gridicon.iconOfType(.chevronDown) - chevronView.tintColor = WPStyleGuide.cellGridiconAccessoryColor() + chevronView.tintColor = .textTertiary + } + } + @IBOutlet var topStroke: UIView! { + didSet { + topStroke.backgroundColor = .divider + } + } + @IBOutlet private var bottomStroke: UIView! { + didSet { + bottomStroke.backgroundColor = .divider } } - @IBOutlet private var bottomStroke: UIView! @IBOutlet private var contentView: UIView! { didSet { contentView.leadingAnchor.constraint(equalTo: contentViewLeadingAnchor).isActive = true @@ -59,6 +68,7 @@ class QuickStartChecklistHeader: UIView { override func awakeFromNib() { super.awakeFromNib() + contentView.backgroundColor = .listForeground prepareForVoiceOver() } } diff --git a/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistHeader.xib b/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistHeader.xib index 58032062f97f..011b1c08eb5d 100644 --- a/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistHeader.xib +++ b/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistHeader.xib @@ -1,11 +1,9 @@ - - - - + + - + @@ -97,6 +95,7 @@ + diff --git a/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistViewController.swift b/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistViewController.swift index b619b7f1579d..1716cd5816d2 100644 --- a/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistViewController.swift +++ b/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistViewController.swift @@ -51,7 +51,7 @@ class QuickStartChecklistViewController: UITableViewController { private lazy var successScreen: NoResultsViewController = { let successScreen = NoResultsViewController.controller() successScreen.view.frame = tableView.bounds - successScreen.view.backgroundColor = .white + successScreen.view.backgroundColor = .listBackground successScreen.configure(title: tasksCompleteScreen.title, subtitle: tasksCompleteScreen.subtitle, image: tasksCompleteScreen.imageName) @@ -151,6 +151,7 @@ private extension QuickStartChecklistViewController { tableView.backgroundView = successScreen.view self.tableView = tableView + WPStyleGuide.configureTableViewColors(view: self.tableView) } func startObservingForQuickStart() { diff --git a/WordPress/Classes/ViewRelated/Blog/QuickStartCongratulationsCell.xib b/WordPress/Classes/ViewRelated/Blog/QuickStartCongratulationsCell.xib index 16252fec96a5..234ef11a91dc 100644 --- a/WordPress/Classes/ViewRelated/Blog/QuickStartCongratulationsCell.xib +++ b/WordPress/Classes/ViewRelated/Blog/QuickStartCongratulationsCell.xib @@ -1,11 +1,9 @@ - - - - + + - + @@ -15,11 +13,11 @@ - +