Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip http/https detection in enqueue and linking #3171

Closed
coenjacobs opened this issue May 14, 2013 · 7 comments
Closed

Strip http/https detection in enqueue and linking #3171

coenjacobs opened this issue May 14, 2013 · 7 comments
Assignees

Comments

@coenjacobs
Copy link
Contributor

According to @mikejolley this can be done by just providing // instead of manually determining if we should enqueue/link via http or https.

@ghost ghost assigned mikejolley May 14, 2013
@maxrice
Copy link
Contributor

maxrice commented May 14, 2013

trac ticket

@coenjacobs
Copy link
Contributor Author

Thanks @maxrice - that confirms it's possible in WordPress since version 3.5, so this is good to go. :)

@pmgarman
Copy link
Contributor

@coenjacobs could have just asked, I've already done this and could have confirmed it for you!

@sjeden
Copy link
Contributor

sjeden commented Aug 9, 2013

@mikejolley

since 57157db

i believe this is broken. styles / js are attempting to enqueue via // not http:// or https://

http://stickers.edenfamily.co.uk/product-category/albums/

@mikejolley
Copy link
Member

// is protocol relative.

@pmgarman
Copy link
Contributor

pmgarman commented Aug 9, 2013

@sjeden this is expected and works perfectly fine :)

@sjeden
Copy link
Contributor

sjeden commented Aug 9, 2013

@mikejolley @pmgarman - clearly a theming issue on my part then. lulz.
been a longgggg day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants