Implement better way to track attribute taxonomies #3149
Labels
type: refactor
The issue/PR is related to refactoring.
Milestone
Comments
|
Cheers team! |
|
Which release did this fix get into? |
|
@paulgibbs This is merged into the master branch, aimed to go out for 2.1 (hasn't been released). I'll discuss with @mikejolley today and see if we can get this into 2.0.15 (to be released soon), as I don't know why this hasn't been merged into an earlier fix release. |
mikejolley
added a commit
that referenced
this issue
Sep 9, 2013
…t_attribute() function Closes #3149. Conflicts: classes/class-wc-post-types.php
|
Merged this into the 2.0.15 branch. |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
woocommerce_terms_clauses()function, we check for all taxonomies havingproduct_catas slug or matchpa_in their slug. Problem appears when using a taxonomy havingpa_in slug that are not WooCommerce attributes.This needs a better way to keep track, possibly by storing all the attribute taxonomy slugs in an option field.
Slightly related to #3064, as it needs a similar solution here imho.
Reported by @paulgibbs, reference: paulgibbs/achievements#101
The text was updated successfully, but these errors were encountered: