From bf21eac5999a01c82e98f758104f8b4979c80f24 Mon Sep 17 00:00:00 2001 From: qwerty287 Date: Sat, 16 Sep 2023 10:29:11 +0200 Subject: [PATCH] Never log tokens --- agent/rpc/auth_interceptor.go | 2 +- server/cron/cron.go | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/agent/rpc/auth_interceptor.go b/agent/rpc/auth_interceptor.go index f4f0887f588..8f13f4c1ba5 100644 --- a/agent/rpc/auth_interceptor.go +++ b/agent/rpc/auth_interceptor.go @@ -107,7 +107,7 @@ func (interceptor *AuthInterceptor) refreshToken() error { } interceptor.accessToken = accessToken - log.Trace().Str("token", accessToken).Msg("Token refreshed") + log.Trace().Msg("token refreshed") return nil } diff --git a/server/cron/cron.go b/server/cron/cron.go index 939386ba79f..d3bf06de3ca 100644 --- a/server/cron/cron.go +++ b/server/cron/cron.go @@ -126,13 +126,14 @@ func CreatePipeline(ctx context.Context, store store.Store, f forge.Forge, cron // the pipeline. if refresher, ok := f.(forge.Refresher); ok { refreshed, err := refresher.Refresh(ctx, creator) - log.Debug().Msgf("token refreshed: %t", refreshed) if err != nil { log.Error().Err(err).Msgf("failed to refresh oauth2 token for creator: %s", creator.Login) } else if refreshed { if err := store.UpdateUser(creator); err != nil { log.Error().Err(err).Msgf("error while updating creator: %s", creator.Login) // move forward + } else { + log.Debug().Msgf("token refreshed for creator: %s", creator.Login) } } }