Skip to content

Commit 29e93bd

Browse files
authored
Never log tokens (#2466)
1 parent a40bb4f commit 29e93bd

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

agent/rpc/auth_interceptor.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func (interceptor *AuthInterceptor) refreshToken() error {
107107
}
108108

109109
interceptor.accessToken = accessToken
110-
log.Trace().Str("token", accessToken).Msg("Token refreshed")
110+
log.Trace().Msg("token refreshed")
111111

112112
return nil
113113
}

server/cron/cron.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -126,13 +126,14 @@ func CreatePipeline(ctx context.Context, store store.Store, f forge.Forge, cron
126126
// the pipeline.
127127
if refresher, ok := f.(forge.Refresher); ok {
128128
refreshed, err := refresher.Refresh(ctx, creator)
129-
log.Debug().Msgf("token refreshed: %t", refreshed)
130129
if err != nil {
131130
log.Error().Err(err).Msgf("failed to refresh oauth2 token for creator: %s", creator.Login)
132131
} else if refreshed {
133132
if err := store.UpdateUser(creator); err != nil {
134133
log.Error().Err(err).Msgf("error while updating creator: %s", creator.Login)
135134
// move forward
135+
} else {
136+
log.Debug().Msgf("token refreshed for creator: %s", creator.Login)
136137
}
137138
}
138139
}

0 commit comments

Comments
 (0)