Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Xtensa Rust and use espflash #52

Merged
merged 5 commits into from
Oct 2, 2023

Conversation

SergioGasquez
Copy link
Contributor

@SergioGasquez SergioGasquez commented Oct 2, 2023

Updates Xtensa Rust version to 1.72
Since esp-rs/rust-build#233 we no longer have python3 installed in the docker image, but espflash is installed, so I switched to use it instead of installing esptool.

Successful CI run: https://github.com/SergioGasquez/wokwi-builders/actions/runs/6377579127

@SergioGasquez SergioGasquez changed the title Use espflash instead of esptool Update Xtensa Rust and use espflash Oct 2, 2023
@urish
Copy link
Contributor

urish commented Oct 2, 2023

Thanks! Looks like there's a merge conflict, mind looking into it?

@urish
Copy link
Contributor

urish commented Oct 2, 2023

Ready to merge?

@SergioGasquez
Copy link
Contributor Author

SergioGasquez commented Oct 2, 2023

Ready to merge?

Just ran the CI again: https://github.com/SergioGasquez/wokwi-builders/actions/runs/6378052193. Lets wait until it finishes just to be safe

@SergioGasquez
Copy link
Contributor Author

Should now be able to merge, CI run: https://github.com/SergioGasquez/wokwi-builders/actions/runs/6378287483

@urish urish merged commit 14a54bb into wokwi:main Oct 2, 2023
@SergioGasquez SergioGasquez deleted the feat/use-espflash branch October 2, 2023 10:19
@urish
Copy link
Contributor

urish commented Oct 2, 2023

New builders are up

@SergioGasquez
Copy link
Contributor Author

Just built all my Wokwi projects successfully: https://github.com/SergioGasquez/wokwi-projects/actions/runs/6379187246!

@urish
Copy link
Contributor

urish commented Oct 2, 2023

Awesome! This one seems to be failing with the new version, however: https://wokwi.com/projects/357451677483992065?build-cache=disable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants