Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo in PDT 4.53 and 4.54 #113

Closed
amilan17 opened this issue Jul 5, 2021 · 10 comments
Closed

Fix Typo in PDT 4.53 and 4.54 #113

amilan17 opened this issue Jul 5, 2021 · 10 comments
Assignees

Comments

@amilan17
Copy link
Member

amilan17 commented Jul 5, 2021

Summary and purpose

Typo in Product definition template 4.53 and Product definition template 4.54. 

Note says "see Code table 4.PTN..".

@amilan17 amilan17 added this to the FT-2022-1 milestone Sep 13, 2021
@amilan17
Copy link
Member Author

amilan17 commented Oct 5, 2021

see Attachment IV - Definition of "tiles" with time dependent attributes

@amilan17
Copy link
Member Author

amilan17 commented Oct 5, 2021

Sibylle and Sebastien can help

@sebvi
Copy link
Contributor

sebvi commented Oct 6, 2021

I have checked the original proposal (From IPET-DRC-IV, document 2.2_5).
There is a table in the proposal called 4.233 but in the actual manual on code 4.233 is something else (aerosol type). I suspect a clash between 2 proposals during that fast track and it eventually became 4.234 (and the template originally numbered 4.52 and 4.53 became 4.53 and 4.54).
I suspect it is that table 4.234 that should be referenced by the templates but we should check with @efucile as he was the proposer of the templates at the time.

@sebvi
Copy link
Contributor

sebvi commented Oct 29, 2021

Hi @amilan17 , did you check with @efucile if my analysis is correct? If yes we could create the branch

@SibylleK
Copy link
Contributor

SibylleK commented Nov 1, 2021

Dear @amilan17, I think "4.PTN" is intended and not a typo, as PTN should be defined in octet 12 in PDT 4.53 or 4.54 and could be either 234 - "Canopy cover fraction" or 236 - "Soil texture fraction".

@amilan17 amilan17 self-assigned this Nov 9, 2021
@efucile
Copy link
Member

efucile commented Nov 11, 2021

Yes @SibylleK you are right. The template was generalised and the Partition Table Number is in octet 12. This is not a typo.

@amilan17
Copy link
Member Author

@efucile @SibylleK does it make sense to replace 4.PTN with Code table 4.234 and Code table 4.236? I ask, because we recently introduced a way in GitHub to reference the code tables in a column. As displayed in the image below. 

@amilan17
Copy link
Member Author

amilan17 commented Dec 8, 2021

@efucile @SibylleK Can you please respond to my question above? I'd like to finalize this for FT22-1 within a week.

@sebvi
Copy link
Contributor

sebvi commented Dec 8, 2021

I think the answer was given in an email: the product definition templates are correct because the table 4.PTN is not predetermined. I can try to dig the email with @efucile comments.

@amilan17 amilan17 removed this from the FT-2022-1 milestone Dec 20, 2021
@amilan17
Copy link
Member Author

no changes needed in CSV or PDF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants