fix waitFor #218
Closed
fix waitFor #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2017 12:03
joint effort with @aarongreenwald
LeoNatan
added
type: enhancement ⚡️
type: bug 🐞
and removed
type: enhancement ⚡️
labels
rotemmiz
reviewed
Aug 1, 2017
| this._call = invoke.call(_conditionCall, 'waitWithTimeout:', invoke.IOS.CGFloat(timeout/1000)); | ||
| await this.execute(); | ||
| await new MatcherAssertionInteraction(this._element, this._originalMatcher).execute(); | ||
| } | ||
| whileElement(searchMatcher) { |
There was a problem hiding this comment.
I believe waitFor...whileElement doesn't fail as well, it needs to be consistent with waitFor...withTimeout
There was a problem hiding this comment.
Also, not conditions are not handled properly. We'll need to fix them as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
joint effort with @aarongreenwald