Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 7 Compatibility #69

Closed
adamski opened this issue Jun 26, 2016 · 8 comments
Closed

iOS 7 Compatibility #69

adamski opened this issue Jun 26, 2016 · 8 comments

Comments

@adamski
Copy link
Contributor

adamski commented Jun 26, 2016

I'm getting an error on running my app on device.

[RCCNavigationController setHidesBarsOnSwipe:]: unrecognized selector sent to instance

I can't find the reference to setHidesBarsOnSwipe anywhere - could this be getting called by iOS?

iPhone 4, iOS v 7.1.2

@adamski
Copy link
Contributor Author

adamski commented Jun 26, 2016

Ah it seems this is because its part of iOS 8. http://stackoverflow.com/questions/28113849/ios-swift-uinavigationcontroller-hidesbarsonswipe-error
Any chance we can make this compatible with 7?

@adamski adamski changed the title [RCCNavigationController setHidesBarsOnSwipe:]: unrecognized selector sent to instance iOS 7 Compatibility Jun 28, 2016
@adamski
Copy link
Contributor Author

adamski commented Jun 28, 2016

There are also 2 classes used that are not available on iOS 7: UIBlurEffect and UIVisualEffectView

@drorbiran
Copy link
Contributor

Hi
We appreciate your pull request, but at this stage, we are not going to adress iOS 7 compability.
Thanks.

@adamski
Copy link
Contributor Author

adamski commented Aug 25, 2016

Ok, will it be something you will consider addressing when merging with react-native-navigation?

@drorbiran
Copy link
Contributor

It's currently not a part of our road map.

@adamski
Copy link
Contributor Author

adamski commented Aug 28, 2016

Seems a shame, as its minimal code changes and has no impact on later iOS versions (that I am aware of) - I am targeting iOS 7 as a minimum in my app, same as React Native.

@DanielZlotin
Copy link
Contributor

DanielZlotin commented Aug 28, 2016

This is targeting less than 3% of the iOS devices in the world (which means less then 1.5% total), and will cost us more development time (also each feature will have to pass QA on 1 more device). Furthermore we will have iOS 10 soon, which means it will drop even further. We have to make compromises for our fast velocity and I think this is a no brainer. Same goes to supporting Android below api15.. Just too little market share to make it worth our time and resources.

@adamski
Copy link
Contributor Author

adamski commented Aug 28, 2016

Fair enough, I understand your position. Thanks for taking the time to explain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants