Skip to content
This repository was archived by the owner on Oct 21, 2024. It is now read-only.

Commit ba953f7

Browse files
committed
log unknown color, add some doc and add : to fileds
1 parent 0cdb337 commit ba953f7

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

Makefile

+2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ kube-describe:
2323
kube-del:
2424
kubectl delete pod -l name=charon -n staging
2525

26+
# wait until is the image deployed
2627
__sleep:
28+
echo 'Waiting for the image deployment.'; \
2729
sleep 20
2830

2931
kube-deploy: kube-del __sleep kube-describe kube-logs

slack/converter/Attachments.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ def get_color(color: Optional[str]) -> str:
3939
clr = '🟢'
4040
elif color == 'danger':
4141
clr = '🚨'
42+
elif color:
43+
logger.info(f'Unknown color: {clr}')
4244

4345
logger.debug(f'Color: {clr}')
4446
return clr
@@ -67,5 +69,5 @@ def get_fields(fields: Optional[List[dict]]) -> str:
6769

6870
logger.debug(f'Fields: {fields}')
6971

70-
data = [f'`{field["title"]}`' + (' ' if field.get('short') else '\n') + field['value'] for field in fields]
72+
data = [f'`{field["title"]}:`' + (' ' if field.get('short') else '\n') + field['value'] for field in fields]
7173
return '\n'.join(data)

0 commit comments

Comments
 (0)