Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Windows): ensure configuration file loading (js and cjs) #602

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

wellwelwel
Copy link
Owner

Currently, using the configuration files as .js and .cjs doesn't load settings on Windows.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (f82ecd7) to head (c64ce70).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   99.13%   97.94%   -1.19%     
==========================================
  Files          26       26              
  Lines        2189     2188       -1     
  Branches      447      430      -17     
==========================================
- Hits         2170     2143      -27     
- Misses         17       39      +22     
- Partials        2        6       +4     
Flag Coverage Δ
linux ?
osx 97.94% <100.00%> (-0.69%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel marked this pull request as ready for review July 25, 2024 10:07
@wellwelwel wellwelwel merged commit 2d53660 into main Jul 25, 2024
27 checks passed
@wellwelwel wellwelwel deleted the windows branch July 25, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant