Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recycle bin #1429

Closed
qicz opened this issue Jan 13, 2018 · 20 comments
Closed

Recycle bin #1429

qicz opened this issue Jan 13, 2018 · 20 comments
Milestone

Comments

@qicz
Copy link

qicz commented Jan 13, 2018

Sometimes accidentally deleted the card, the hope can put them in the Sometimes accidentally deleted the card, the hope can put them in the bin, can restore bin, can restore. or remove the "delete" the card / list function.

@xet7
Copy link
Member

xet7 commented Jan 15, 2018

@BruceZCQ

For that purpose, there is archive card and list, and restore:
https://github.com/wekan/wekan/wiki/Features#lists-add-archive-and-restore-archived-delete-list

Deleting really deletes permanently.

@xet7 xet7 closed this as completed Jan 15, 2018
@qicz
Copy link
Author

qicz commented Jan 15, 2018

No, I mean because I accidentally deleted the card, can't recover, if can have a recycle bin, can restore a accidentally deleted.

@qicz
Copy link
Author

qicz commented Jan 15, 2018

remove follow code

`'click .js-delete': Popup.afterConfirm('cardDelete', function () {
    Popup.close();
    Cards.remove(this._id);
    Utils.goBoardId(this.boardId);
  }),`

or

`'click .js-delete': Popup.afterConfirm('cardDelete', function () {
    Popup.close();
    Cards.putToTrash(this._id); //Cards.remove(this._id);
    Utils.goBoardId(this.boardId);
  }),`

@xet7
Copy link
Member

xet7 commented Jan 15, 2018

@BruceZCQ

Do you mean that "Archive this card" functionality is too complicated and hard to understand?

Should these be renamed?

  • "Archive this card or list" => "Delete this card or list"
  • "Archived cards/lists" => "Recycle Bin"

And should there be "Empty Recycle Bin" on top of those?

Then, if somebody accidentally empties Recycle Bin or some card/list there, is it OK ?
Or should there be additional recovery steps?

@ocdtrekkie

What do you think?

@xet7 xet7 reopened this Jan 15, 2018
@qicz
Copy link
Author

qicz commented Jan 16, 2018

@xet7 @ocdtrekkie

I don't mean to close before ‘Archive’ function, also is not to say that they are not easy to understand, or need to rename the funcation.

I just want a new function, somebody deleted cards or lists move to the recycle bin, the people manage their own recycle bin.

‘Archive’ or ‘Archived’ just store the archived cards or lists. if I don't be careful delete the card or list, there is not exist in the Archived list. so I must to recreate the card or list again.

@hever
Copy link

hever commented May 4, 2018

Hey, I don't think that this was good idea. Archive is better than recycle bin for me. I'm using wekan for 1 month (and I'm happy) and still searching for Archive function. I want to place my completed card somewhere, where it will be stored for the future. And place it into the 'recycle bin' seems to be a not good idea.

By the way, it could be nice, if I can move card with drag&drop to archive (as I see this feature in trello).

@xet7
Copy link
Member

xet7 commented May 4, 2018

@hever

For me, Recycle Bin is more familiar than Archive. I really like it.

Trello seems to have Archive button. I did not find a way to archive with drag and drop.

@hever
Copy link

hever commented May 4, 2018

@xet7 I'm sory, not Trello. Taiga.

@hever
Copy link

hever commented May 4, 2018

About Archive vs Recycle bin - I'm user of Gmail. There is Recycle bin place where you move email when you want to delete it. And you can move it to the Archive, when you want to store it forever. And have ability to find it in future. Maybe, it's something what i would like to have in wekan. Users may think that after some time cards in Recycle bin will be deleted automatically.

@xet7 xet7 reopened this May 4, 2018
@xet7
Copy link
Member

xet7 commented May 4, 2018

@hever

In Windows, Recycle bin is not emptied automatically. It's more like that, Windows files and or Wekan cards. Throwing card to trash, restoring it back to board.

There is no "Move to archive" in Gmail and Windows.

@hever
Copy link

hever commented May 4, 2018

So maye it cloud be good ideal, if there will be recycle bin and archive together. Archive for that you want to store forever and recycle bin for that you want to delete maybe after some time.

@ocdtrekkie
Copy link
Contributor

I don't think Wekan should auto-perma-delete anything. Email auto-deletes from trash, but that makes sense given the volume of email people get. No operating system would delete your files automatically though, no matter how long they're in the trash.

Archive does lend itself to mean something you're likely to keep historically, and Recycle Bin/Trash suggests you are getting rid of it, but unless there's a difference in functionality, arguing about which to use is more or less bikeshedding.

@xet7
Copy link
Member

xet7 commented May 4, 2018

You can rename some board like "Archive 2017" and move cards to it.

@xet7 xet7 closed this as completed May 4, 2018
@hever
Copy link

hever commented May 4, 2018

@ocdtrekkie I think so that autodeleting is not good. User may always delete card as they're do it elsewhere.

@xet7 There may be problem if one board is shared by many peoples. Then you have to create archive-board per normal-board and set them same people. Weird. I have last list named Archive, but I dont want to everytime look at many historical cards that have been done. What I speak about Taiga is in this video (look at it for few second). https://youtu.be/FnMBZ5ZVwjs?t=3m50s This principle is very nice. Wekan is better than Taiga, but this is great.

I think, normal is this:
delete -> recycle bin -> delete forever
archive -> archive

Sorry for commenting closed issue, again.

@xet7 xet7 added this to the v0.81 milestone May 6, 2018
@xet7
Copy link
Member

xet7 commented Nov 9, 2018

No, Recycle Bin will stay as Recycle Bin. This is now added to FAQ, with reasons why.
https://github.com/wekan/wekan/wiki/FAQ#policy-about-wekan-ui-changes

@hever
Copy link

hever commented Nov 9, 2018

Hey, Gmail's auto emptying recycle bin after 30 days is not bug. It's normal function and has sense.

But okay, cards in recycle bin doing slow down of board so it's not good for archive. I understand. So there's could be feature request for archive function that create new board (where members will be every time same as in original board) with one list archive and archiving cards to this place. Would it be?

@xet7
Copy link
Member

xet7 commented Nov 9, 2018

@hever

I added IFTTT Rules feature request #1996 . When card is moved to some list, it's only possible to automatically move it to Recycle Bin, not other board yet.

Well, when I can find option to stop Gmail from deleting emails automatically from Recycle Bin, I will stop calling it a bug. Windows Recycle Bin afaik does not automatically delete files. And I do not know any other software that automatically deletes something.

@hever
Copy link

hever commented Nov 9, 2018

We have recycle bin in office and the cleaner comes up from time to time and emptied it - and it's not bug it's valid. The same behavior in my home (there's no cleaner but wife do the job). Everywhere is recycle bin a place where you do not know day or hour if everything you put in is still there. Gmail has clearly rules and there is no sense to disable it. If you want it, you do something bad. If you want to review what you earlier don't want before you lost it forever then move it to some folder but no to recycle bin (also in home, office, etc.). Moving something to recycle bin means, you are going to risky way and you can lost it (wifes and cleaners are unpredictable).

@xet7
Copy link
Member

xet7 commented Nov 9, 2018

Yes it's risky. It slows down Wekan a lot when keeping a lot of cards on same board or Recycle Bin. Changing it's name to Archive does not solve anything. Now your Archive is full and slows down Wekan board and you need to click Empty Archive. Emptying Archive is like Emptying .Zip archive or Emptying Book Library. It does not make any sense. Recycle Bin is not Archive. And you really should not Archive to same board.

@xet7
Copy link
Member

xet7 commented Nov 10, 2018

@hever

Sorry Wekan still has only Recycle Bin.

I added Feature Request for unlimited cards and unlimited archive #1999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants