require validateSchema and optionsValidationError from webpack #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Is there any way to keep webpack on the process variable? Global vs local installations was failing cause local/global paths wasn't resolving correctly. |
|
Thanks! Gotta do some more work on this before we can submit the fix! |
nning
added a commit
to nning/imgshr
that referenced
this pull request
Jun 2, 2018
Finish when webpack/webpack-cli#478 is released
evenstensberg
added a commit
that referenced
this pull request
Jun 2, 2018
* fix: require validateSchema and optionsValidationError from webpack (#478) * fix: fix lookups
|
Thanks @ev1stensberg ! glad to have put in my two pennies worth 👍 |
|
Helped us triage the bug in order to fix that quickly, thanks again @juliantellez ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix:
The new version of webpack-cli adds webpack to the global process object.
This causes applications such as webpack-dev-derver to break since it assumes that
process.webpackModuleis available in the current process.This pr simply reverts this assumption.
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information