Escape PHP executable (#162)

Author: theofidry

src/Input/ChildCommandFactory.php

@@ -19,6 +19,7 @@
 use function array_filter;
 use function array_map;
 use function array_merge;
+use function explode;
 use function Safe\getcwd;
 use function sprintf;
 
@@ -64,7 +65,7 @@ private function createBaseCommand(
         InputInterface $input
     ): array {
         return array_filter([
-            $this->phpExecutable,
+            ...$this->getEscapedPhpExecutable(),
             $this->scriptPath,
             $this->commandName,
             ...array_map('strval', self::getArguments($input)),
@@ -87,6 +88,14 @@ private function getForwardedOptions(InputInterface $input): array
         );
     }
 
+    /**
+     * @return list<string>
+     */
+    private function getEscapedPhpExecutable(): array
+    {
+        return explode(' ', $this->phpExecutable);
+    }
+
     /**
      * @return list<string|bool|int|float|null|array<string|bool|int|float|null>>
      */

src/ParallelExecutorFactory.php

@@ -320,7 +320,6 @@ public function withProgressSymbol(string $progressSymbol): self
     }
 
     /**
-     * TODO: although it is a string maybe it has additional options, ensure those are escaped
      * The path of the PHP executable. It is the executable that will be used
      * to spawn the child process(es).
      */

tests/Input/ChildCommandFactoryTest.php

@@ -245,6 +245,31 @@ public static function childProvider(): iterable
                 ],
             ];
         })();
+
+        yield 'enriched PHP executable' => (static function () use (
+            $scriptPath,
+            $commandName
+        ) {
+            [$input, $commandDefinition] = self::createInput(
+                [],
+                [],
+            );
+
+            return [
+                '/path/to/php -dmemory_limit=1',
+                $scriptPath,
+                $commandName,
+                $commandDefinition,
+                $input,
+                [
+                    '/path/to/php',
+                    '-dmemory_limit=1',
+                    $scriptPath,
+                    $commandName,
+                    '--child',
+                ],
+            ];
+        })();
     }
 
     public function test_it_cannot_create_a_factory_with_an_invalid_script_path(): void