Add test for CpuCoreCounter (#192)

Author: theofidry

phpunit.xml.dist

@@ -13,6 +13,7 @@
     </php>
 
     <extensions>
+        <extension class="Webmozarts\Console\Parallelization\PHPUnit\ResetCpuCounterListener"/>
         <extension class="Webmozarts\StrictPHPUnit\StrictPHPUnitExtension"/>
     </extensions>
 

src/CpuCoreCounter.php

@@ -14,7 +14,6 @@
 namespace Webmozarts\Console\Parallelization;
 
 use Webmozart\Assert\Assert;
-use function getenv;
 
 /**
  * @internal
@@ -37,7 +36,7 @@ public static function getNumberOfCpuCores(): int
             return self::$count = 1;
         }
 
-        $count = getenv('WEBMOZARTS_CONSOLE_PARALLELIZATION_CPU_COUNT');
+        $count = $_ENV['WEBMOZARTS_CONSOLE_PARALLELIZATION_CPU_COUNT'];
 
         if (false !== $count) {
             Assert::numeric($count);

tests/CpuCoreCounterTest.php

@@ -0,0 +1,44 @@
+<?php
+
+/*
+ * This file is part of the Webmozarts Console Parallelization package.
+ *
+ * (c) Webmozarts GmbH <office@webmozarts.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Webmozarts\Console\Parallelization;
+
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @covers \Webmozarts\Console\Parallelization\CpuCoreCounter
+ *
+ * @internal
+ */
+final class CpuCoreCounterTest extends TestCase
+{
+    public function test_can_get_the_number_of_cpu_cores(): void
+    {
+        $cpuCoresCount = CpuCoreCounter::getNumberOfCpuCores();
+
+        self::assertGreaterThan(0, $cpuCoresCount);
+    }
+
+    public function test_can_get_the_number_of_cpu_cores_defined(): void
+    {
+        $cleanUp = EnvironmentVariables::setVariables([
+            'WEBMOZARTS_CONSOLE_PARALLELIZATION_CPU_COUNT' => '7',
+        ]);
+
+        $cpuCoresCount = CpuCoreCounter::getNumberOfCpuCores();
+
+        $cleanUp();
+
+        self::assertSame(7, $cpuCoresCount);
+    }
+}

tests/EnvironmentVariables.php

@@ -57,7 +57,7 @@ private static function setVariable(string $name, string $value): callable
         if (array_key_exists($name, $_ENV)) {
             $previousValue = $_ENV[$name];
 
-            $restoreEnv = static fn () => $_SERVER[$name] = $previousValue;
+            $restoreEnv = static fn () => $_ENV[$name] = $previousValue;
         } else {
             $restoreEnv = static function () use ($name): void {
                 unset($_ENV[$name]);

tests/PHPUnit/ResetCpuCounterListener.php

@@ -0,0 +1,45 @@
+<?php
+
+/*
+ * This file is part of the Webmozarts Console Parallelization package.
+ *
+ * (c) Webmozarts GmbH <office@webmozarts.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Webmozarts\Console\Parallelization\PHPUnit;
+
+use PHPUnit\Runner\AfterTestHook;
+use ReflectionClass;
+use ReflectionProperty;
+use Webmozarts\Console\Parallelization\CpuCoreCounter;
+
+final class ResetCpuCounterListener implements AfterTestHook
+{
+    private static ?ReflectionProperty $countReflection;
+
+    public function executeAfterTest(string $test, float $time): void
+    {
+        self::resetCounter();
+    }
+
+    private static function getCountReflection(): ReflectionProperty
+    {
+        if (!isset(self::$countReflection)) {
+            self::$countReflection = (new ReflectionClass(CpuCoreCounter::class))->getProperty('count');
+            self::$countReflection->setAccessible(true);
+        }
+
+        return self::$countReflection;
+    }
+
+    private static function resetCounter(): void
+    {
+        $countReflection = self::getCountReflection();
+        $countReflection->setValue(new CpuCoreCounter(), null);
+    }
+}