Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/helm separate deployments #164

Merged

Conversation

edrichhans
Copy link
Contributor

@edrichhans edrichhans commented Jul 29, 2024

EDIT 2024-08-21

Hi!

I didn't mean to create a PR in this public repo, as I wanted to use this personally and just see the diff. But if this turned out to be useful, then I am happy that this got merged!

@fredsted
Copy link
Collaborator

Hi, thanks for this. One thing - I think you should remove the kubernetes folder with this. :-)

@fredsted fredsted merged commit 7f10c9f into webhooksite:master Jul 31, 2024
@mowies
Copy link

mowies commented Aug 5, 2024

Documentation is still pointing to the kubernetes folder and doesn't mention a helm chart at all

@fredsted
Copy link
Collaborator

fredsted commented Aug 5, 2024

@mowies Please make a PR then :-)

@mowies
Copy link

mowies commented Aug 5, 2024

I don't even know what this is about. The PR doesn't have a description and there's no issue attached either...

@fredsted
Copy link
Collaborator

fredsted commented Aug 5, 2024

@mowies Looks like you meant the docs site (?) I've made an update there so it links to the helm folder.

@mowies
Copy link

mowies commented Aug 5, 2024

thanks!
with this change, it still got a bit harder to install the tool directly from the repo, since helm can't just fetch the folder and use the chart there. it either needs a hosted chart repo or a .tgz archive that contains the chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants