Implement validation rule for min and max length individually

Author: webhkp

src/Rules/MaxLength.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Webhkp\Pvalidate\Rules;
+
+use Attribute;
+
+#[Attribute(Attribute::TARGET_PROPERTY)]
+class MaxLength extends Length {
+    public function __construct(
+        readonly private float $length
+    ) {
+        parent::__construct(max: $length);
+    }
+}

src/Rules/MinLength.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Webhkp\Pvalidate\Rules;
+
+use Attribute;
+
+#[Attribute(Attribute::TARGET_PROPERTY)]
+class MinLength extends Length {
+    public function __construct(
+        readonly private float $length
+    ) {
+        parent::__construct(min: $length);
+    }
+}

tests/Feature/LengthValidationTest.php

@@ -1,6 +1,8 @@
 <?php
 
 use Webhkp\Pvalidate\Rules\Length;
+use Webhkp\Pvalidate\Rules\MaxLength;
+use Webhkp\Pvalidate\Rules\MinLength;
 use Webhkp\Pvalidate\ValidationBuilder;
 use Webhkp\Pvalidate\Validator;
 
@@ -20,6 +22,12 @@ public function __construct() {
 
         #[Length(min: 20, max: 50)]
         public string $fourthString = 'my fourth string';
+
+        #[MinLength(20)]
+        public string $minLengthTestString = 'abc';
+
+        #[MaxLength(10)]
+        public string $maxLengthTestString = 'abc def ghi jkl mno';
     };
 });
 
@@ -30,6 +38,8 @@ public function __construct() {
             $this->testObj->secondString = "abc def ghi jkl mno pqr stu vwx yz";
             $this->testObj->thirdString = "abc def";
             $this->testObj->fourthString = "abc def ghi jkl mno pqr stu vwx yz";
+            $this->testObj->minLengthTestString = "abc def ghi jkl mno pqr stu vwx yz";
+            $this->testObj->maxLengthTestString = "abc def";
 
             $validationResponse = Validator::validate($this->testObj);
 
@@ -41,7 +51,7 @@ public function __construct() {
             $validationResponse = Validator::validate($this->testObj);
 
             expect($validationResponse->isValid())->toBeFalse();
-            expect($validationResponse->getErrors())->toHaveKeys(['firstString', 'secondString', 'thirdString', 'fourthString']);
+            expect($validationResponse->getErrors())->toHaveKeys(['firstString', 'secondString', 'thirdString', 'fourthString', 'minLengthTestString', 'maxLengthTestString']);
         });
     });
 
@@ -52,6 +62,34 @@ public function __construct() {
             expect($validation->isValid())->toBeFalse();
             expect($validation->getErrors())->toHaveKeys(['length.errors.maxLength']);
         });
+
+        it('Should return error for minLength violation', function () {
+            $validation = ValidationBuilder::minLength(20)->safeParse('abc def');
+
+            expect($validation->isValid())->toBeFalse();
+            expect($validation->getErrors())->toHaveKeys(['minLength.errors.minLength']);
+        });
+
+        it('Should return error for maxLength violation', function () {
+            $validation = ValidationBuilder::maxLength(20)->safeParse('abc def ghi jkl mno pqr stu vwx yz');
+
+            expect($validation->isValid())->toBeFalse();
+            expect($validation->getErrors())->toHaveKeys(['maxLength.errors.maxLength']);
+        });
+
+        it('Should return error for length(min or max) violation', function () {
+            $validation = ValidationBuilder::minLength(10)->maxLength(20);
+
+            $validationResult = $validation->safeParse('abc');
+
+            expect($validationResult->isValid())->toBeFalse();
+            expect($validationResult->getErrors())->toHaveKeys(['minLength.errors.minLength']);
+
+            $validationResult = $validation->safeParse('abc def ghi jkl mno pqr stu vwx yz');
+
+            expect($validationResult->isValid())->toBeFalse();
+            expect($validationResult->getErrors())->toHaveKeys(['maxLength.errors.maxLength']);
+        });
     });
 });
 

tests/Unit/MaxLengthTest.php

@@ -0,0 +1,28 @@
+<?php
+
+use Webhkp\Pvalidate\Exceptions\PvalidateException;
+use Webhkp\Pvalidate\Rules\MaxLength;
+
+beforeEach(function () {
+    $this->rule = new MaxLength(10);
+});
+
+describe("MaxLength validation", function () {
+    it('Should be valid', function () {
+        $validationResult = $this->rule->safeParse('abc');
+
+        expect($validationResult->isValid())->toBeTrue();
+        expect($validationResult->getErrors())->toBeEmpty();
+    });
+
+    it('Should return \'maxLength\' error on safeParse', function () {
+        $validationResult = $this->rule->safeParse('abc def ghi jkl mno');
+
+        expect($validationResult->isValid())->toBeFalse();
+        expect($validationResult->getErrors())->toHaveKey('maxLength');
+    });
+
+    it('Should throw exception on parse', function () {
+        $this->rule->parse('abc def ghi jkl mno');
+    })->throws(PvalidateException::class);
+});

tests/Unit/MinRuleTest.php

@@ -0,0 +1,28 @@
+<?php
+
+use Webhkp\Pvalidate\Exceptions\PvalidateException;
+use Webhkp\Pvalidate\Rules\MinLength;
+
+beforeEach(function () {
+    $this->rule = new MinLength(10);
+});
+
+describe("MinLength validation", function () {
+    it('Should be valid', function () {
+        $validationResult = $this->rule->safeParse('abc def ghi jkl mno');
+
+        expect($validationResult->isValid())->toBeTrue();
+        expect($validationResult->getErrors())->toBeEmpty();
+    });
+
+    it('Should return \'minLength\' error on safeParse', function () {
+        $validationResult = $this->rule->safeParse('abc');
+
+        expect($validationResult->isValid())->toBeFalse();
+        expect($validationResult->getErrors())->toHaveKey('minLength');
+    });
+
+    it('Should throw exception on parse', function () {
+        $this->rule->parse('abc');
+    })->throws(PvalidateException::class);
+});