-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improve performance of CI job #978
Open
mato533
wants to merge
12
commits into
main
Choose a base branch
from
ta/ci/rebuild
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f921fd
to
ed2128f
Compare
Will look at this after the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:ci
Updates to Continuous Integration
area:dependencies
Updating dependencies
area:performance
Issues affecting performance
component:electron-builder
Electron Builder issues
component:electron-forge
Electron Forge issues
release:future
Include in a future release (not the next one)
semver:patch
Changes that don't affect the API (bug fixes)
track:main
For the current stable version track
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following changes are proposed with the primary goal of optimising the performance of the CI pipeline
If cache is work, The runtime is 5min.(Before this change 8~10min)
Basic direction
Aim to improve performance by maximising parallel distributed execution while paying attention to the maximum number of concurrent executions, while making effective use of Turbo parallel execution and sequential execution based on job dependency definitions.
Changeset
Independence of Build jobs (.github/workflows/ci-build.yml)
Ensure that all tests use the build results in Linux that are used when the actual NPM package is installed. We believe this will improve the quality of E2E testing.
Independence of Setup jobs as common action (.github/workflows/actions/setup-workspace)
The following multi-step processes are now common.
pnpm install
with cacheCreate actions upload/download artifact (.github/workflows/actions/download-archive, upload-archive)
The following usage are use this action.
Independence of lint and unit-test job (.github/workflows/ci-lint.yml, .github/workflows/ci-unit.yml)
The process for utilising a single build result has been combined as a stand-alone workflow and changed to be called from the CI pipeline.
Independence of E2E (.github/workflows/ci-e2e.yml)
While leveraging the features of Turbo, we have made it independent as a standard workflow for running E2E.
Rebuild CI pipeline (.github/workflows/ci.yml)
Reconfigured to run E2E tests as distributed and parallel as possible by combining the above jobs.
Disable debug log at e2e test scripts
The e2e log files now could be downloaded, It seems to no need to output its logs to GitHub actions log.
Remarks
Tasks