Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BN.js dependecy to v5.2.1 #5072

Closed
2 tasks done
gregorfelkar opened this issue May 25, 2022 · 2 comments
Closed
2 tasks done

Update BN.js dependecy to v5.2.1 #5072

gregorfelkar opened this issue May 25, 2022 · 2 comments
Assignees
Labels
1.x 1.0 related issues

Comments

@gregorfelkar
Copy link

This is not a Bug Report, Feature Request, or related to Documentation

  • I have searched the existing issues

Is there an existing issue for this?

  • I have searched the existing issues

What's up?

  • Fix serious issue in .toString(16)

The hex encoding of some numbers is wrong. Since the string representation
is also used for interoperability between BigInt libraries, this bug is
causing a number modification when a BN.js number is converted into
another BigInt class, for example the BigNumber of ethers.js.

indutny/bn.js@042ab62

Currently it will install:

│ └─┬ web3-utils@1.7.3
│   ├── bn.js@4.12.0

Examples/References

No response

@plusminushalf
Copy link

Hey I am new to the repo, will this be a good first issue? If yes I would like to pick this up.

@luu-alex luu-alex added the 1.x 1.0 related issues label May 25, 2022
@luu-alex
Copy link
Contributor

Thank you for this @gregorfelkar this looks serious and we'll update BN as soon as we can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

No branches or pull requests

4 participants