You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the formatParam function in web3-eth-abi package is mutating the input parameters. That can have side effects and may result in introducing bugs. Would be nice fix it.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.
Expected behavior
No input parameters should be mutated.
Actual behavior
Currently the
formatParam
function inweb3-eth-abi
package is mutating the input parameters. That can have side effects and may result in introducing bugs. Would be nice fix it.https://github.com/ChainSafe/web3.js/blob/d9726d41babe14bc823d5d2ea4e4af15ef5914ac/packages/web3-eth-abi/src/utils.ts#L120
https://github.com/ChainSafe/web3.js/blob/a1c7d71973ec17f9287fbea8939e64a80e589fc6/packages/web3-eth-abi/src/index.js#L249
Environment
1.x, 4.x
The text was updated successfully, but these errors were encountered: