Skip to content

Commit a63935c

Browse files
authored
HTML: review followup (#12662)
Follow up to review comments in #12636.
1 parent 3588ed9 commit a63935c

File tree

1 file changed

+8
-2
lines changed
  • html/webappapis/dynamic-markup-insertion/opening-the-input-stream

1 file changed

+8
-2
lines changed

html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.js

+8-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ test(t => {
33
t.add_cleanup(() => frame.remove());
44
assert_equals(frame.contentDocument.URL, "about:blank");
55
assert_equals(frame.contentWindow.location.href, "about:blank");
6-
frame.contentDocument.open();
6+
assert_equals(frame.contentDocument.open(), frame.contentDocument);
77
assert_equals(frame.contentDocument.URL, document.URL);
88
assert_equals(frame.contentWindow.location.href, document.URL);
99
}, "document.open() changes document's URL (fully active document)");
@@ -26,7 +26,7 @@ async_test(t => {
2626

2727
frame.onload = t.step_func_done(() => {
2828
// Now childDoc is still active but no longer fully active.
29-
childDoc.open();
29+
assert_equals(childDoc.open(), childDoc);
3030
assert_equals(childDoc.URL, blankURL);
3131
assert_equals(childWin.location.href, blankURL);
3232
});
@@ -40,6 +40,9 @@ test(t => {
4040
t.add_cleanup(() => frame.remove());
4141
const doc = frame.contentDocument;
4242

43+
// We do not test for win.location.href in this test due to
44+
// https://github.com/whatwg/html/issues/3959.
45+
4346
// Right now the frame is connected and it has an active document.
4447
assert_equals(doc.URL, "about:blank");
4548

@@ -55,6 +58,9 @@ async_test(t => {
5558
const frame = document.createElement("iframe");
5659
t.add_cleanup(() => frame.remove());
5760

61+
// We do not test for win.location.href in this test due to
62+
// https://github.com/whatwg/html/issues/3959.
63+
5864
frame.onload = t.step_func(() => {
5965
const doc = frame.contentDocument;
6066
// Right now the frame is connected and it has an active document.

0 commit comments

Comments
 (0)