Skip to content

Commit 8787b74

Browse files
[Credentialless] Fix flakes about iframeTest.js
In the various tests, there are up to 8 <iframe> navigating concurrently. There are no ways to detect an <iframe> fails to load other than using a timeout. See whatwg/html#125. The 3000ms timeout was sometimes too short. This cause flakes. To reduce the rate of false positive, the timeout has been increased to 6000ms. R:titouan@chromium.org CC:lyf@chromium.org Fixed:1215956 Bug:1175099 Change-Id: I7bedccb351ff62d55b6020403aac5457608e5497
1 parent 32407bd commit 8787b74

File tree

1 file changed

+1
-1
lines changed
  • html/cross-origin-embedder-policy/credentialless/resources

1 file changed

+1
-1
lines changed

html/cross-origin-embedder-policy/credentialless/resources/iframeTest.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const iframeTest = function(
6161
// There are no interoperable ways to check an iframe failed to load. So a
6262
// timeout is being used.
6363
// See https://github.com/whatwg/html/issues/125
64-
step_timeout(()=>send(test_token, "block"), 3000);
64+
step_timeout(()=>send(test_token, "block"), 6000);
6565

6666
assert_equals(await receive(test_token), expectation);
6767
}, description);

0 commit comments

Comments
 (0)