Skip to content

"Add tag" and "Annotate" missing in context menu (Android 12) #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madalu opened this issue Nov 4, 2021 · 3 comments · May be fixed by #1451
Open

"Add tag" and "Annotate" missing in context menu (Android 12) #1215

madalu opened this issue Nov 4, 2021 · 3 comments · May be fixed by #1451
Labels
Milestone

Comments

@madalu
Copy link

madalu commented Nov 4, 2021

After the upgrade to Android 12 on a Pixel 3a, I find that "Add tag" and "Annotate" no longer appear in the context menu after selecting text. However, they do appear if I select text and then (while the context menu is open) scroll the screen, turn the screen on and off, swipe into the app switcher and then return to the app, swipe notifications up and down, etc. (basically anything that redraws or refreshes the screen).

This seems to be the relevant issue on the Google bug tracker: https://issuetracker.google.com/issues/200172520
Google marked it as "won't fix" with the following comment:

It is a hack to override the onActionModeStarted to modify the menu item list. onActionModeStarted was just meant to notify the app that the action mode was started. It didn't meant to be a place for developers to update the menus. The correct way to do that is to provide your own ActionMode.Callback and update your menu items in either onCreateActionMode and onPrepareActionMode.

Steps to reproduce the issue (on Android 12)

  1. Select text within a Wallabag article
  2. Notice "Add tag" and "Annotate" (if annotations are enabled) are missing from the menu
  3. Perform an action that redraws or refreshes the screen (scroll, swipe notifications down and back up, etc.)
  4. Notice "Add tag" and (optionally) "Annotate" are present in the menu.

Environment details

  • wallabag app version: 2.4.3
  • wallabag app installation source: F-Droid
  • Android OS version: Android 12
  • Android ROM: Stock
  • Android hardware: Pixel 3a
@di72nn di72nn added this to the 2.4.4 milestone Nov 20, 2021
@anarcat
Copy link

anarcat commented Jan 29, 2022

confirmed on latest Calyx OS update to Android 12 on a Pixel 4a.

and nice bug report by the way, complete with the upstream reference (and fix!!)

@di72nn di72nn added the Bug label Jan 29, 2022
@di72nn
Copy link
Member

di72nn commented Jan 29, 2022

Yeah, thanks for the detailed bug report!

I tried to address it back in November, but I think I encountered some problems.
I've been quite busy lately, but I'll see if I can give it another shot soon.

@shtrom
Copy link
Contributor

shtrom commented Dec 6, 2022

@di72nn do you have a branch with your attempts handy? I have the same issue on a Pixel 6a/Android 13, and would like to try fixing it.

@nvllz nvllz linked a pull request Mar 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants