Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lightpush protocol to handle unsupported pubsub topics with clear error codes #2773

Closed
1 task
gabrielmer opened this issue Jun 4, 2024 · 2 comments
Labels
effort/hours Estimated to be completed in a few hours

Comments

@gabrielmer
Copy link
Contributor

Background

The lightpush protocol itself should never be aware of the sharded format of pubsub topics. It is an extension of libp2p's gossipsub.
On a protocol level, the lightpush service node needs to handle requests on unsupported pubsub topics by returning a clear error code.

Acceptance criteria

  • Update lightpush protocol to handle unsupported pubsub topics with clear error codes.
@gabrielmer gabrielmer added the effort/hours Estimated to be completed in a few hours label Jun 4, 2024
@gabrielmer gabrielmer moved this to To Do in Waku Jun 4, 2024
@NagyZoltanPeter
Copy link
Contributor

@gabrielmer : I think its clearly part of #2722 WDYT?

@gabrielmer
Copy link
Contributor Author

@gabrielmer : I think its clearly part of #2722 WDYT?

Oh 100%! Will close it as duplicate! Thank you!

@gabrielmer gabrielmer closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to be completed in a few hours
Projects
Archived in project
Development

No branches or pull requests

2 participants