feat: Logger with log levels #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
weboko
reviewed
Oct 19, 2023
| this._warn = debug(Logger.createDebugNamespace("WARN", prefix)); | ||
| this._error = debug(Logger.createDebugNamespace("ERROR", prefix)); | ||
|
|
||
| this._info.log = console.info.bind(console); |
There was a problem hiding this comment.
Nothing is better than good old console.* 😄
There was a problem hiding this comment.
is this compatible with libp2p logging approach?
There was a problem hiding this comment.
it isn't -- #1677 re-enables that functionality @fryorcraken
weboko
approved these changes
Oct 19, 2023
danisharora099
force-pushed
the
feat/loglevel
branch
from
5ec0f58 to
176f2c0
Compare
danisharora099
added a commit
that referenced
this pull request
Oct 20, 2023
* setup a custom Logger with log level support * refactor codebase for to use new Logger with log levels * disallow usage of `debug` directly / only allow usage in/through custom Logger * remove `debug` from logger
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently use the native
debugfor all logging purposes.This is tricky -- while we want to add as many logs as possible to ensure smooth debugging, information travel, etc, we also don't want to limit readability & flood logs.
Solution
Allow usage of segregating logs by level:
log.info(),log.warn()-- this would enable library consumers to choose the log level they want to watch, help us add as many logs as possible based on the level.Notes
debugandconsolepackages by creating a wrapper to allow of log levels and prefixes to keep things lightweight without adding dependency on a new packagedebugpackage across the codebase directly, and only allow usage through theLoggerclass