Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error when no response on subscription #1567

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Sep 13, 2023

Problem

Turned out there is a runtime error when no response is received.

Solution

Throw an error when that happens.

Notes

@weboko weboko requested a review from a team as a code owner September 13, 2023 20:56
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 28.79 KB (0%) 576 ms (0%) 1.4 s (+6.58% 🔺) 2 s
Waku Simple Light Node 309.81 KB (+0.01% 🔺) 6.2 s (+0.01% 🔺) 5.4 s (+76.1% 🔺) 11.6 s
ECIES encryption 28.68 KB (0%) 574 ms (0%) 1.7 s (+17.58% 🔺) 2.3 s
Symmetric encryption 28.68 KB (0%) 574 ms (0%) 1.5 s (+6% 🔺) 2.1 s
DNS discovery 118.59 KB (0%) 2.4 s (0%) 1.9 s (-28.2% 🔽) 4.3 s
Privacy preserving protocols 122.6 KB (0%) 2.5 s (0%) 1.9 s (-31.08% 🔽) 4.3 s
Light protocols 29.25 KB (+0.11% 🔺) 585 ms (+0.11% 🔺) 716 ms (-19.03% 🔽) 1.4 s
History retrieval protocols 28.34 KB (0%) 567 ms (0%) 886 ms (-5.23% 🔽) 1.5 s
Deterministic Message Hashing 5.64 KB (0%) 113 ms (0%) 337 ms (-34.13% 🔽) 450 ms

@weboko weboko merged commit d049ebb into master Sep 14, 2023
@weboko weboko deleted the weboko/filter-logs branch September 14, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant