Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify sending/receiving API #1220

Closed
4 tasks done
fryorcraken opened this issue Mar 7, 2023 · 4 comments
Closed
4 tasks done

feat: simplify sending/receiving API #1220

fryorcraken opened this issue Mar 7, 2023 · 4 comments
Assignees

Comments

@fryorcraken
Copy link
Collaborator

fryorcraken commented Mar 7, 2023

This is a bug report/feature or change request/support request

Problem

From discussion waku-org/waku-react#1 (comment)

we can have the Light node and relay node implement an interface like that

interface WakuNode {
   sender: Sender;
   receiver: Receiver
}

Proposed Solutions

  • Create ISender and IReceiver interfaces
  • relay, filter, light push to implement these interfaces
  • take the opportunity to align API for these protocols
  • enables Waku node to also implement the interfaces and use lightpush+filter or relay under the hood (user only need to choose what protocol to use at node creation)

Notes

Other improvement:

Make filter.subscribe and probably relay.addObserver too accept a single decoder OR an array of decoder.

@fryorcraken fryorcraken added this to Waku Mar 7, 2023
@fryorcraken fryorcraken mentioned this issue Mar 7, 2023
13 tasks
@fryorcraken fryorcraken moved this to In Progress in Waku Mar 7, 2023
@fryorcraken fryorcraken moved this from In Progress to Code Review / QA in Waku Mar 23, 2023
@weboko
Copy link
Collaborator

weboko commented Apr 3, 2023

I believe it is done by #1219 and #1217 being merged

@weboko weboko closed this as completed Apr 3, 2023
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Apr 3, 2023
@fryorcraken
Copy link
Collaborator Author

Last check point is missing: having .send and .subscribe methods directly on the Waku interface.

@fryorcraken fryorcraken reopened this Apr 24, 2023
@fryorcraken fryorcraken moved this from Done to To Do in Waku Apr 24, 2023
@weboko weboko moved this from To Do to In Progress in Waku May 15, 2023
@weboko weboko moved this from In Progress to Code Review / QA in Waku May 17, 2023
@weboko
Copy link
Collaborator

weboko commented May 31, 2023

Last PR to close the issue waku-org/examples.waku.org#239

@fryorcraken fryorcraken moved this from Code Review / QA to In Progress in Waku Jun 1, 2023
@weboko
Copy link
Collaborator

weboko commented Jun 1, 2023

Closed with the PR being merged

@weboko weboko closed this as completed Jun 1, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants