change shardinfo terminology with RFC

Author: danisharora099

packages/core/src/lib/stream_manager.ts

@@ -55,10 +55,10 @@ export class StreamManager {
   }
 
   private prepareNewStream(peer: Peer): void {
-    const streamPromise = this.newStream(peer).catch(() => {
+    const streamPromise = this.newStream(peer).catch((error) => {
       // No error thrown as this call is not triggered by the user
       this.log.error(
-        `Failed to prepare a new stream for ${peer.id.toString()}`
+        `Failed to prepare a new stream for ${peer.id.toString()}: ${error}`
       );
     });
     this.streamPool.set(peer.id.toString(), streamPromise);

packages/interfaces/src/enr.ts

@@ -18,10 +18,9 @@ export interface Waku2 {
   lightPush: boolean;
 }
 
-//TODO: adhere to terminology from the metadata protocol
 export interface ShardInfo {
-  cluster: number;
-  indexList: number[];
+  clusterId: number;
+  shards: number[];
 }
 
 export interface IEnr extends Map<ENRKey, ENRValue> {

packages/utils/src/common/sharding.ts

@@ -3,11 +3,34 @@ import type { PubSubTopic, ShardInfo } from "@waku/interfaces";
 export const shardInfoToPubSubTopics = (
   shardInfo: ShardInfo
 ): PubSubTopic[] => {
-  return shardInfo.indexList.map(
-    (index) => `/waku/2/rs/${shardInfo.cluster}/${index}`
+  return shardInfo.shards.map(
+    (index) => `/waku/2/rs/${shardInfo.clusterId}/${index}`
   );
 };
 
+export const pubSubTopicToShardInfo = (topic: PubSubTopic): ShardInfo => {
+  const parts = topic.split("/"); // Split the topic string into parts
+
+  if (
+    parts.length === 6 &&
+    parts[1] === "waku" &&
+    parts[2] === "2" &&
+    parts[3] === "rs"
+  ) {
+    const cluster = parts[4];
+    const index = parts[5];
+
+    return {
+      clusterId: parseInt(cluster),
+      shards: [parseInt(index)]
+    };
+  } else {
+    throw new Error(
+      `Invalid topic ${topic}. Expected format: /waku/2/rs/<cluster>/<index>`
+    );
+  }
+};
+
 export function ensurePubsubTopicIsConfigured(
   pubsubTopic: PubSubTopic,
   configuredTopics: PubSubTopic[]